RESOLVED FIXED 55991
Change plugins to use their own executable on Mac OS X 
https://bugs.webkit.org/show_bug.cgi?id=55991
Summary Change plugins to use their own executable on Mac OS X
Sam Weinig
Reported 2011-03-08 19:16:54 PST
Change plugins to use their own executable on Mac OS X
Attachments
Patch (29.23 KB, patch)
2011-03-08 19:21 PST, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-03-08 19:18:53 PST
<rdar://problem/9049659>
Sam Weinig
Comment 2 2011-03-08 19:21:18 PST
Created attachment 85125 [details] Patch
mitz
Comment 3 2011-03-08 20:06:54 PST
Comment on attachment 85125 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85125&action=review > Source/WebKit2/Configurations/PluginProcess.xcconfig:1 > +// Copyright (C) 2011 Apple Inc. All rights reserved. I think this should say 2010-2011, since the original was first published in 2010. > Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm:217 > + const char* args[] = { [processAppExecutablePath fileSystemRepresentation], frameworkExecutablePath, "-type", processTypeAsString(m_launchOptions.processType), "-servicename", serviceName.data(), "-localization", localization.data(), 0 }; Seems like the type can be inferred from the name now.
Alexey Proskuryakov
Comment 4 2011-03-09 00:56:47 PST
> I think this should say 2010-2011 "2010, 2011", that is.
Sam Weinig
Comment 5 2011-03-09 10:07:11 PST
Fixed in r80646. I kept the -type since Anders thinks it is ok, we can remove it later if necessary.
Note You need to log in before you can comment on or make changes to this bug.