Bug 55978 - WebKit2: Redo is broken
Summary: WebKit2: Redo is broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Jeff Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-08 15:49 PST by Jeff Miller
Modified: 2011-03-08 16:18 PST (History)
0 users

See Also:

Attachments
Patch (1.83 KB, patch)
2011-03-08 15:53 PST, Jeff Miller 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Miller 2011-03-08 15:49:14 PST 
If you undo an edit command, you cannot redo it.  This is because WebEditCommandProxy::unapply() and WebEditCommandProxy::reapply() are registering the wrong edit command when an undo or redo happens.  For example, when we unapply(), we should register a Redo command, not an Undo command.
Comment 1 Jeff Miller 2011-03-08 15:53:03 PST 
Created attachment 85103 [details]
Patch
Comment 2 Jeff Miller 2011-03-08 16:18:50 PST 
Committed r80603: <http://trac.webkit.org/changeset/80603>