Bug 55976 - Provisional URL should be loaded when restoring session state even if there are back / forward list entries
Summary: Provisional URL should be loaded when restoring session state even if there a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Mark Rowe (bdash)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-08 15:33 PST by Mark Rowe (bdash)
Modified: 2011-06-18 12:29 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.39 KB, patch)
2011-03-08 15:35 PST, Mark Rowe (bdash) 		beidson: review+
beidson: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Mark Rowe (bdash) 2011-03-08 15:35:53 PST 
Created attachment 85100 [details]
Patch
Comment 2 Brady Eidson 2011-03-08 15:38:18 PST 
Comment on attachment 85100 [details]
Patch

Looks fine.  Except I'm wondering if the sandboxExtensionHandle is needed in the new message also?  I am - admittedly - not sure why we needed it in the old message, and therefore don't know if we need it in the new one also.
Comment 3 Mark Rowe (bdash) 2011-03-08 15:40:27 PST 
(In reply to comment #2)
> (From update of attachment 85100 [details])
> Looks fine.  Except I'm wondering if the sandboxExtensionHandle is needed in the new message also?  I am - admittedly - not sure why we needed it in the old message, and therefore don't know if we need it in the new one also.

WebPage::restoreSessionAndNavigateToCurrentItem passes it to goToBackForwardItem.  It’s not used at all within restoreSession.

Thanks for the review!