WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
55976
Provisional URL should be loaded when restoring session state even if there are back / forward list entries
https://bugs.webkit.org/show_bug.cgi?id=55976
Summary
Provisional URL should be loaded when restoring session state even if there a...
Mark Rowe (bdash)
Reported
2011-03-08 15:33:44 PST
As per the FIXME at <
http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/cf/WebPageProxyCF.cpp?rev=80391#L175
>.
Attachments
Patch
(4.39 KB, patch)
2011-03-08 15:35 PST
,
Mark Rowe (bdash)
beidson
: review+
beidson
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1
2011-03-08 15:35:53 PST
Created
attachment 85100
[details]
Patch
Brady Eidson
Comment 2
2011-03-08 15:38:18 PST
Comment on
attachment 85100
[details]
Patch Looks fine. Except I'm wondering if the sandboxExtensionHandle is needed in the new message also? I am - admittedly - not sure why we needed it in the old message, and therefore don't know if we need it in the new one also.
Mark Rowe (bdash)
Comment 3
2011-03-08 15:40:27 PST
(In reply to
comment #2
)
> (From update of
attachment 85100
[details]
) > Looks fine. Except I'm wondering if the sandboxExtensionHandle is needed in the new message also? I am - admittedly - not sure why we needed it in the old message, and therefore don't know if we need it in the new one also.
WebPage::restoreSessionAndNavigateToCurrentItem passes it to goToBackForwardItem. It’s not used at all within restoreSession. Thanks for the review!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug