Bug 5597 – REGRESSION (412.2-416.12): [[xxx]] appears on page instead of JS correctly parsing translated variables

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Geoffrey Garen]

This bug is also in Radar as <rdar://4323773>

The latest OS update causes a regression bug in javascript. This is a bug that I noticed recently in the 
webkit (just started to do my own builds)... and should be (IMHO) be considered a show-stopper. 

The broken javascript functionality is best seen if you try to view a TiddlyWiki web page. You can go to 
the TiddlyWiki website to view < http://www.tiddlywiki.com/ > 

I have not yet tried to pinpoint where the broken methods are.... but you will notice that there are a lot 
of [[foobar]] phrases on the site... where the browser should instead be parsing out translated variables. 

This regression can be seen if compared to the 10.4.2 OS release of the webkit.

[Darin Adler]

Bug 5571 contains an earlier report of this same thing (on a page that shows an even worse symptom on 
TOT).

Created attachment 4567 [details]
Testcase?

This tests for the regression in 416.12 that causes the page to break.
That regression does not exist in TOT, where the page breaks for another reason
(a separate RegEx regression in TOT).

[Darin Adler]

So the bug here is that if a regular expression character class has any characters > 255 in it, it won't 
match anything. Instead the intent was to ignore characters > 255, but it seems that instead we do 
something wrong with the entire character class.

Should be straightforward to fix, but not on TOT, since this is only for 10.4.3 (so we might not want to use 
bugzilla to track this 10.4.3-only issue any more).

[Darin Adler]

What we do in 10.4.3 with characters > 255 is reject the entire regular expression. I guess that's what we 
need to fix. We can probably instead turn anything > 255 into a 255.

[Darin Adler]

With my patch for bug 5602 in place, the reduction here works fine as does the test case attached to that 
bug. But http://tiddlywiki.com still doesn't work.

(In reply to comment #5)
> With my patch for bug 5602 in place, the reduction here works fine as does the test case attached to 
that 
> bug. But http://tiddlywiki.com still doesn't work.

Looks like TOT has a problem with characters >255 in RegExp as well (but one that this bug's testcase 
doesn't detect), since with the current patch for bug 5602, if you replace all such characters in regex 
patterns in the tiddlywiki source with \u00ff, it works.

Created attachment 4580 [details]
Testcase!

This slightly more elaborate testcase fails on TOT as well.

[Geoffrey Garen]

The fix for 5571 fixes this.