Bug 55953 – [Qt][Symbian] Building QtTestBrowser alone on symbian fix

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Tools / Tests

[Mahesh Kulkarni]

Build fix for building QtTestBrowser alone from webkit/Tools/QtTestBrowser on symbian. As the test browser doesnt get built by default building it individually complains about the local API's mismatch. Simple fix to use local qtwebkit headers instead from epoc32/include

[Mahesh Kulkarni]

Created attachment 85067 [details]
patch

simple fix for building qtTestBrowser alone from webkit/Tools/QtTestbrowser on symbian and make it use locally built header files instead of epoc32 headers

[Alexis Menard (darktears)]

Comment on attachment 85067 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85067&action=review

> Tools/ChangeLog:5
> +        [QT][S60] Building QtTestBrowser alone on symbian fix

[QT] -> [Qt]

> Tools/ChangeLog:8
> +        Include local headers for qtwebkit build instead of epoc32 headers for symbian.

qtwebkit -> QtWebKit

[Laszlo Gombos]

Mahesh, the way we usually solve this problem is the following (see for example WebCore.pri):

# On Symbian PREPEND_INCLUDEPATH is the best way to make sure that WebKit headers
# are included before platform headers.
symbian {
    PREPEND_INCLUDEPATH = $$OUTPUT_DIR/include/QtWebKit $$QT.script.includes $$PREPEND_INCLUDEPATH
} else {
    INCLUDEPATH = $$OUTPUT_DIR/include/QtWebKit $$QT.script.includes $$INCLUDEPATH
}

Can you give it a try ?

[Simon Hausmann]

Comment on attachment 85067 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85067&action=review

I'm going to say r+, but please fix the style issues before landing

> Tools/QtTestBrowser/QtTestBrowser.pro:27
> +symbian:INCLUDEPATH+=../../Source/include/QtWebKit

Style nitpick: space after : and before/after +=

[Mahesh Kulkarni]

Marking this as wontfix as actual fix is to support --install-headers option of build-webkit script, which will be raised as new bug.