Bug 55948 - IndexedDB: Add BackingStoreImpl parameter to IDBFactoryBackendInterface::open
Summary: IndexedDB: Add BackingStoreImpl parameter to IDBFactoryBackendInterface::open
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Hans Wennborg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-08 10:24 PST by Hans Wennborg
Modified: 2011-03-09 04:06 PST (History)
3 users (show)

See Also:

Attachments
Patch (12.84 KB, patch)
2011-03-08 10:26 PST, Hans Wennborg 		jorlow: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Wennborg 2011-03-08 10:24:24 PST 
IndexedDB: Add BackingStoreImpl parameter to IDBFactoryBackendInterface::open
Comment 1 Hans Wennborg 2011-03-08 10:26:23 PST 
Created attachment 85058 [details]
Patch
Comment 2 Jeremy Orlow 2011-03-08 10:43:50 PST 
Comment on attachment 85058 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85058&action=review

r=me

> Source/WebCore/storage/IDBFactoryBackendInterface.h:54
> +    enum BackingStoreImpl {

BackingStoreType is probably more clear.

> Source/WebKit/chromium/public/WebIDBFactory.h:54
> +    enum BackingStoreImpl {

BackingStoreImpl sounds like it's the actual implementation.  Maybe BackingStoreType?

> Source/WebKit/chromium/src/IDBFactoryBackendProxy.h:48
> +    virtual void open(const String& name, PassRefPtr<IDBCallbacks>, PassRefPtr<SecurityOrigin>, Frame*, const String& dataDir, int64_t maximumSize, IDBFactoryBackendInterface::BackingStoreImpl = DefaultBackingStore);

The default shouldn't be necessary, right?

> Source/WebKit/chromium/src/WebIDBFactoryImpl.h:45
> +    virtual void open(const WebString& name, WebIDBCallbacks*, const WebSecurityOrigin&, WebFrame*, const WebString& dataDir, unsigned long long maximumSize, WebIDBFactory::BackingStoreImpl = DefaultBackingStore);

default isn't necessary i think
Comment 3 Hans Wennborg 2011-03-09 04:01:14 PST 
(In reply to comment #2)
> (From update of attachment 85058 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85058&action=review
> 
> r=me
> 
> > Source/WebCore/storage/IDBFactoryBackendInterface.h:54
> > +    enum BackingStoreImpl {
> 
> BackingStoreType is probably more clear.
> 
> > Source/WebKit/chromium/public/WebIDBFactory.h:54
> > +    enum BackingStoreImpl {
> 
> BackingStoreImpl sounds like it's the actual implementation.  Maybe BackingStoreType?
Yup, that's better. Doing that.

> 
> > Source/WebKit/chromium/src/IDBFactoryBackendProxy.h:48
> > +    virtual void open(const String& name, PassRefPtr<IDBCallbacks>, PassRefPtr<SecurityOrigin>, Frame*, const String& dataDir, int64_t maximumSize, IDBFactoryBackendInterface::BackingStoreImpl = DefaultBackingStore);
> 
> The default shouldn't be necessary, right?
> 
> > Source/WebKit/chromium/src/WebIDBFactoryImpl.h:45
> > +    virtual void open(const WebString& name, WebIDBCallbacks*, const WebSecurityOrigin&, WebFrame*, const WebString& dataDir, unsigned long long maximumSize, WebIDBFactory::BackingStoreImpl = DefaultBackingStore);
> 
> default isn't necessary i think
Right. Removing.
Comment 4 Hans Wennborg 2011-03-09 04:06:09 PST 
Committed r80635: <http://trac.webkit.org/changeset/80635>