Bug 55948 – IndexedDB: Add BackingStoreImpl parameter to IDBFactoryBackendInterface::open

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Hans Wennborg]

IndexedDB: Add BackingStoreImpl parameter to IDBFactoryBackendInterface::open

[Hans Wennborg]

Created attachment 85058 [details]
Patch

[Jeremy Orlow]

Comment on attachment 85058 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85058&action=review

r=me

> Source/WebCore/storage/IDBFactoryBackendInterface.h:54
> +    enum BackingStoreImpl {

BackingStoreType is probably more clear.

> Source/WebKit/chromium/public/WebIDBFactory.h:54
> +    enum BackingStoreImpl {

BackingStoreImpl sounds like it's the actual implementation.  Maybe BackingStoreType?

> Source/WebKit/chromium/src/IDBFactoryBackendProxy.h:48
> +    virtual void open(const String& name, PassRefPtr<IDBCallbacks>, PassRefPtr<SecurityOrigin>, Frame*, const String& dataDir, int64_t maximumSize, IDBFactoryBackendInterface::BackingStoreImpl = DefaultBackingStore);

The default shouldn't be necessary, right?

> Source/WebKit/chromium/src/WebIDBFactoryImpl.h:45
> +    virtual void open(const WebString& name, WebIDBCallbacks*, const WebSecurityOrigin&, WebFrame*, const WebString& dataDir, unsigned long long maximumSize, WebIDBFactory::BackingStoreImpl = DefaultBackingStore);

default isn't necessary i think

[Hans Wennborg]

(In reply to comment #2)
> (From update of attachment 85058 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85058&action=review
> 
> r=me
> 
> > Source/WebCore/storage/IDBFactoryBackendInterface.h:54
> > +    enum BackingStoreImpl {
> 
> BackingStoreType is probably more clear.
> 
> > Source/WebKit/chromium/public/WebIDBFactory.h:54
> > +    enum BackingStoreImpl {
> 
> BackingStoreImpl sounds like it's the actual implementation.  Maybe BackingStoreType?
Yup, that's better. Doing that.

> 
> > Source/WebKit/chromium/src/IDBFactoryBackendProxy.h:48
> > +    virtual void open(const String& name, PassRefPtr<IDBCallbacks>, PassRefPtr<SecurityOrigin>, Frame*, const String& dataDir, int64_t maximumSize, IDBFactoryBackendInterface::BackingStoreImpl = DefaultBackingStore);
> 
> The default shouldn't be necessary, right?
> 
> > Source/WebKit/chromium/src/WebIDBFactoryImpl.h:45
> > +    virtual void open(const WebString& name, WebIDBCallbacks*, const WebSecurityOrigin&, WebFrame*, const WebString& dataDir, unsigned long long maximumSize, WebIDBFactory::BackingStoreImpl = DefaultBackingStore);
> 
> default isn't necessary i think
Right. Removing.

[Hans Wennborg]

Committed r80635: <http://trac.webkit.org/changeset/80635>