Bug 55940 - WebKit2 should support Ignore policy from injected bundle client
Summary: WebKit2 should support Ignore policy from injected bundle client
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.6
: P2 Normal
Assignee: John Sullivan
Depends on:
Reported: 2011-03-08 07:11 PST by John Sullivan
Modified: 2011-03-08 13:20 PST (History)
1 user (show)

See Also:

Patch to add WKBundlePagePolicyActionIgnore (2.22 KB, patch)
2011-03-08 07:14 PST, John Sullivan
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Sullivan 2011-03-08 07:11:31 PST
Currently WebKit2 supports only WKBundlePagePolicyActionPassThrough and WKBundlePagePolicyActionUse from the injected bundle client. It should also support an Ignore policy, so clients don't have to take a round trip through the UI process in order to ignore a request.
Comment 1 John Sullivan 2011-03-08 07:14:35 PST
Created attachment 85047 [details]
Patch to add WKBundlePagePolicyActionIgnore
Comment 2 John Sullivan 2011-03-08 10:12:26 PST
Fixed in r80568
Comment 3 Sam Weinig 2011-03-08 11:21:49 PST
This patch was wrong. If you add Ignore, you have to add it for all the policy delegates, not just one of them.
Comment 4 John Sullivan 2011-03-08 12:04:00 PST
Agreed. I'll revert this patch.
Comment 5 John Sullivan 2011-03-08 13:20:09 PST
Reverted in 80585.