Bug 55939 – Web Inspector: resource errors are not reported before front-end is opened

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Andrey Kosyakov]

1. run Tools/Scripts/run-webkit-tests
2. Navigate to http://localhost:8000/inspector/console-resource-errors.html
3. Open WebInspector
4. Observe console is empty
5. reload
6. Observe resource errors are logged to console

[Andrey Kosyakov]

Created attachment 85051 [details]
patch

[Alexey Proskuryakov]

Could this have been done for performance reasons?

[Andrey Kosyakov]

(In reply to comment #2)
> Could this have been done for performance reasons?

I don't think we have much to spare there, considering the overhead of resource load. As long as we're sotring other error messages with no inspector front-end, I don't see why we shouldn't save resource errors. I think this used to work up until recently, so it must be just a bug.

[Pavel Feldman]

Comment on attachment 85051 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85051&action=review

> Source/WebCore/inspector/InspectorInstrumentation.cpp:441
> +    if (hasFrontends()) {

Timeline agent does not exist outside front-end lifetime.

> Source/WebCore/inspector/InspectorInstrumentation.cpp:454
> +    if (!hasFrontends())

Same for resource agent. What you should do is look up appropriate InspectorAgent instance and make consoleAgent call on it.

> Source/WebCore/inspector/InspectorInstrumentation.h:674
> +    if (cookie.first)

We want to make sure that instrumentation is a no-op while there is no front-end. There are exceptional cases such as resource error reporting that should be handled manually.

[Andrey Kosyakov]

Created attachment 85148 [details]
patch

- call didReceiveResourceResponseImpl() unconditionally, retrieve agent from loader's frame if missing in cookie
- also fixed didFailLoding

[Andrey Kosyakov]

Created attachment 85160 [details]
patch

[Andrey Kosyakov]

Manually committed r80639: http://trac.webkit.org/changeset/80639