WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
55938
IDBCallbacks::onsuccess(IDBIndex*) is unused and should be removed.
https://bugs.webkit.org/show_bug.cgi?id=55938
Summary
IDBCallbacks::onsuccess(IDBIndex*) is unused and should be removed.
Andrei Popescu
Reported
2011-03-08 06:32:43 PST
IDBCallbacks::onsuccess(IDBIndex*) is unused and should be removed.
Attachments
Patch
(9.46 KB, patch)
2011-03-08 06:37 PST
,
Andrei Popescu
no flags
Details
Formatted Diff
Diff
Patch
(9.46 KB, patch)
2011-03-08 07:32 PST
,
Andrei Popescu
steveblock
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Andrei Popescu
Comment 1
2011-03-08 06:37:51 PST
Created
attachment 85046
[details]
Patch
Hans Wennborg
Comment 2
2011-03-08 06:44:11 PST
looks good
Steve Block
Comment 3
2011-03-08 07:18:29 PST
Comment on
attachment 85046
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=85046&action=review
> Source/WebCore/ChangeLog:8 > +
https://bugs.webkit.org/show_bug.cgi?id=55938
Should be ... <bug summary> <bug url> <additional details> <test status>
> Source/WebKit/chromium/public/WebIDBCallbacks.h:-53 > - virtual void onSuccess(WebIDBObjectStore*) { WEBKIT_ASSERT_NOT_REACHED(); }
Is this a leftover from jorlow's recent patch to remove this method?
> Source/WebKit/chromium/src/WebIDBObjectStoreImpl.cpp:31 > +#include "IDBIndexBackendInterface.h"
Intentional?
Andrei Popescu
Comment 4
2011-03-08 07:32:27 PST
Created
attachment 85049
[details]
Patch
Andrei Popescu
Comment 5
2011-03-08 07:34:07 PST
(In reply to
comment #3
)
> (From update of
attachment 85046
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=85046&action=review
> > > Source/WebCore/ChangeLog:8 > > +
https://bugs.webkit.org/show_bug.cgi?id=55938
> > Should be ... > > <bug summary> > <bug url> > > <additional details> > > <test status> >
Done.
> > Source/WebKit/chromium/public/WebIDBCallbacks.h:-53 > > - virtual void onSuccess(WebIDBObjectStore*) { WEBKIT_ASSERT_NOT_REACHED(); } > > Is this a leftover from jorlow's recent patch to remove this method? >
No, it's a leftover from my previous patch to remove onscucess(IDBObjectStore). I could not remove that method until doing the Chrome-side changes:
http://src.chromium.org/viewvc/chrome?view=rev&revision=77281
Now that that's in, I can clean this up, too.
> > Source/WebKit/chromium/src/WebIDBObjectStoreImpl.cpp:31 > > +#include "IDBIndexBackendInterface.h" > > Intentional?
Yes, this was included transitively via WebIDBCallbacks.h. But since I removed it from that header, I had to add it here.
Steve Block
Comment 6
2011-03-08 07:37:04 PST
Comment on
attachment 85049
[details]
Patch r=me
Andrei Popescu
Comment 7
2011-03-08 08:05:49 PST
Committed
r80564
: <
http://trac.webkit.org/changeset/80564
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug