Bug 55917 - [EFL] Adjust functions of ScrollbarEfl.cpp to WebKit coding style
Summary: [EFL] Adjust functions of ScrollbarEfl.cpp to WebKit coding style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-07 19:26 PST by Gyuyoung Kim
Modified: 2011-03-07 23:05 PST (History)
6 users (show)

See Also:


Attachments
Patch (7.17 KB, patch)
2011-03-07 20:17 PST, Gyuyoung Kim
tkent: review+
tkent: commit-queue+
Details | Formatted Diff | Diff
Modified Patch (7.20 KB, patch)
2011-03-07 21:10 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2011-03-07 19:26:02 PST
ScrollbarEfl.cpp uses efl coding style. WebCore's efl port needs to follow WebKit style.
Comment 1 Gyuyoung Kim 2011-03-07 20:17:43 PST
Created attachment 85014 [details]
Patch

I change variables with more meaningful name.
Comment 2 Kent Tamura 2011-03-07 20:28:02 PST
Comment on attachment 85014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85014&action=review

> Source/WebCore/platform/efl/ScrollbarEfl.cpp:176
> +        message->val[0] = pos / (float)(tSize - vSize);

We prefer C++-style casts though the style guide doesn't mention it.  This should be static_cast<float>(tSize - vSize).

> Source/WebCore/platform/efl/ScrollbarEfl.cpp:178
> +        message->val[0] = 0.0;

See "Floating point literals" in http://www.webkit.org/coding/coding-style.html
> do not append .0, .f and .0f to floating point literals.
Comment 3 Gyuyoung Kim 2011-03-07 21:10:33 PST
Created attachment 85017 [details]
Modified Patch

I fix your point. :-)
Comment 4 WebKit Commit Bot 2011-03-07 23:05:16 PST
Comment on attachment 85017 [details]
Modified Patch

Clearing flags on attachment: 85017

Committed r80540: <http://trac.webkit.org/changeset/80540>
Comment 5 WebKit Commit Bot 2011-03-07 23:05:22 PST
All reviewed patches have been landed.  Closing bug.