Webkit2 not sending UAZoomFocusChanged notifications TO REPRO -Turn on zoom -Set zoom to follow keyboard focus -Test zoom in TextEdit that zoom is following keyboard focus -Start Safari&Webkit2 -Type text into a text field on a webpage RESULTS -Zoom does not follow KB focus
The problem is that we cannot convert the view bounds to screen coordinates because that method is not implemented in WK2 (whereas it is in WK1)
Created attachment 85006 [details] patch
Attachment 85006 [details] did not build on win: Build output: http://queues.webkit.org/results/8106635
Comment on attachment 85006 [details] patch This breaks Windows, but otherwise looks good.
Attachment 85006 [details] did not build on qt: Build output: http://queues.webkit.org/results/8103752
Created attachment 85054 [details] patch
Attachment 85054 [details] did not build on qt: Build output: http://queues.webkit.org/results/8112013
Comment on attachment 85054 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=85054&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1182 > +WebCore::IntRect WebPage::windowToScreen(const WebCore::IntRect& rect) > +{ > + WebCore::IntRect screenRect; No need for the WebCore:: prefix here in the cpp file, although you do need it in the header. > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1185 > + sendSync(Messages::WebPageProxy::WindowToScreen(rect), > + Messages::WebPageProxy::WindowToScreen::Reply(screenRect)); We normally don’t line up parentheses like this. in WebKit code. In fact, all on one line is the normal style.
Attachment 85054 [details] did not build on win: Build output: http://queues.webkit.org/results/8104927
http://trac.webkit.org/changeset/80569