Bug 55916 – AX: Webkit2 not sending UAZoomFocusChanged notifications

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

Webkit2 not sending UAZoomFocusChanged notifications

TO REPRO
-Turn on zoom
-Set zoom to follow keyboard focus
-Test zoom in TextEdit that zoom is following keyboard focus
-Start Safari&Webkit2
-Type text into a text field on a webpage

RESULTS
-Zoom does not follow KB focus

[chris fleizach]

The problem is that we cannot convert the view bounds to screen coordinates because that method is not implemented in WK2 (whereas it is in WK1)

[chris fleizach]

Created attachment 85006 [details]
patch

[Build Bot]

Attachment 85006 [details] did not build on win:
Build output: http://queues.webkit.org/results/8106635

[Sam Weinig]

Comment on attachment 85006 [details]
patch

This breaks Windows, but otherwise looks good.

[Early Warning System Bot]

Attachment 85006 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8103752

[chris fleizach]

Created attachment 85054 [details]
patch

[Early Warning System Bot]

Attachment 85054 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8112013

[Darin Adler]

Comment on attachment 85054 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85054&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1182
> +WebCore::IntRect WebPage::windowToScreen(const WebCore::IntRect& rect)
> +{
> +    WebCore::IntRect screenRect;

No need for the WebCore:: prefix here in the cpp file, although you do need it in the header.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1185
> +    sendSync(Messages::WebPageProxy::WindowToScreen(rect), 
> +             Messages::WebPageProxy::WindowToScreen::Reply(screenRect));

We normally don’t line up parentheses like this. in WebKit code. In fact, all on one line is the normal style.

[Build Bot]

Attachment 85054 [details] did not build on win:
Build output: http://queues.webkit.org/results/8104927

[chris fleizach]

http://trac.webkit.org/changeset/80569