Bug 55904 - selectionHasStyle should call selectionStartHasStyle when shouldToggleStyleBasedOnStartOfSelection
Summary: selectionHasStyle should call selectionStartHasStyle when shouldToggleStyleBa...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on: 55902
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-07 13:45 PST by Ryosuke Niwa
Modified: 2017-07-18 08:29 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-03-07 13:45:06 PST
Currently, EditorCommand is responsible for checking the value returned by shouldToggleStyleBasedOnStartOfSelection and calling either selectionHasStyle or selectionStartHasStyle.  However, each port also calls selectionHasStyle in Source/WebKit without calling shouldToggleStyleBasedOnStartOfSelection and causing Mac port to behave inconsistently.  We should merge these two functions so that selectionHasStyle calls selectionStartHasStyle as needed.
Comment 1 Ryosuke Niwa 2011-03-07 22:46:51 PST
Mn... this bug might be invalid after all.  We do call selectionHasStyle in WebKit but only for text direction. And it seems odd to determine the direction of text merely based at the selection start.