Bug 55881 - Split JNIBridgeJSC.cpp/h into JavaArrayJSC.cpp/h and JavaFieldJSC.cpp/h
Summary: Split JNIBridgeJSC.cpp/h into JavaArrayJSC.cpp/h and JavaFieldJSC.cpp/h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Steve Block
URL:
Keywords:
Depends on: 55774
Blocks:
  Show dependency tree / graph
 
Reported: 2011-03-07 09:10 PST by Steve Block
Modified: 2011-03-07 13:24 PST (History)
5 users (show)

See Also:

Attachments
Patch 1 (54.21 KB, patch)
2011-03-07 09:19 PST, Steve Block 		no flags Details | Formatted Diff | Diff
Patch 2 (54.21 KB, patch)
2011-03-07 10:17 PST, Steve Block 		jorlow: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2011-03-07 09:10:27 PST 
Split JNIBridgeJSC.cpp/h into JavaArrayJSC.cpp/h and JavaFieldJSC.cpp/h
Comment 1 Steve Block 2011-03-07 09:19:13 PST 
Created attachment 84951 [details]
Patch 1
Comment 2 Steve Block 2011-03-07 10:17:46 PST 
Created attachment 84954 [details]
Patch 2
Comment 3 Jeremy Orlow 2011-03-07 10:21:25 PST 
Comment on attachment 84954 [details]
Patch 2

rubber stamp = me  (only skimmed)
Comment 4 Steve Block 2011-03-07 10:50:58 PST 
Committed r80476: <http://trac.webkit.org/changeset/80476>
Comment 5 WebKit Review Bot 2011-03-07 11:10:44 PST 
http://trac.webkit.org/changeset/80476 might have broken Qt Linux Release
Comment 6 Steve Block 2011-03-07 13:24:41 PST 
Looks like the Qt build break was due to a later change - http://trac.webkit.org/changeset/80478 - not sure why my change was on the blame list. In any case, the break was fixed in http://trac.webkit.org/changeset/80480.