Bug 55879 - Rename JNIBridgeV8.cpp/h to JavaFieldV8.cpp/h
Summary: Rename JNIBridgeV8.cpp/h to JavaFieldV8.cpp/h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Steve Block
URL:
Keywords:
Depends on: 55774
Blocks:
  Show dependency tree / graph
 
Reported: 2011-03-07 08:14 PST by Steve Block
Modified: 2011-03-07 14:47 PST (History)
5 users (show)

See Also:

Attachments
Patch 1 (13.55 KB, patch)
2011-03-07 08:19 PST, Steve Block 		no flags Details | Formatted Diff | Diff
Patch 2 (13.68 KB, patch)
2011-03-07 08:21 PST, Steve Block 		no flags Details | Formatted Diff | Diff
Patch 3 (13.59 KB, patch)
2011-03-07 10:58 PST, Steve Block 		jorlow: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2011-03-07 08:14:08 PST 
Rename JNIBridgeV8.cpp/h to JavaFieldV8.cpp/h
Comment 1 Steve Block 2011-03-07 08:19:13 PST 
Created attachment 84947 [details]
Patch 1
Comment 2 Steve Block 2011-03-07 08:21:23 PST 
Created attachment 84948 [details]
Patch 2
Comment 3 Steve Block 2011-03-07 08:24:33 PST 
Looks like the patch won't apply properly until the patch in Bug 55774 lands.
Comment 4 Steve Block 2011-03-07 10:58:41 PST 
Created attachment 84956 [details]
Patch 3
Comment 5 Jeremy Orlow 2011-03-07 11:02:57 PST 
Comment on attachment 84956 [details]
Patch 3

rubber stamp = me
Comment 6 Steve Block 2011-03-07 13:53:39 PST 
Committed r80494: <http://trac.webkit.org/changeset/80494>
Comment 7 WebKit Review Bot 2011-03-07 14:44:33 PST 
http://trac.webkit.org/changeset/80494 might have broken Chromium Mac Release
Comment 8 Steve Block 2011-03-07 14:47:23 PST 
> http://trac.webkit.org/changeset/80494 might have broken Chromium Mac Release
The break appears unrelated to my change.

In file included from /Users/chrome-bot/Desktop/WebKit-BuildSlave/chromium-mac-release/build/Source/WebCore/WebCore.gyp/../platform/cf/RunLoopTimerCF.cpp:30:
../platform/RunLoopTimer.h:32:26: error: SchedulePair.h: No such file or directory

http://build.webkit.org/builders/Chromium%20Mac%20Release/builds/20334/steps/compile-webkit/logs/stdio