Bug 55863 – REGRESSION(r80458): caused tests to crash on several chromium bots (Requested by ukai on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/80458 broke the build:
caused tests to crash on several chromium bots (Requested by ukai on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 84927 [details]
ROLLOUT of r80458

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.

[Fumitoshi Ukai]

Comment on attachment 84927 [details]
ROLLOUT of r80458

Clearing flags on attachment: 84927

Committed r80461: <http://trac.webkit.org/changeset/80461>

[Fumitoshi Ukai]

All reviewed patches have been landed.  Closing bug.

[Fumitoshi Ukai]

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=fast%2Fjs%2Fcyclic-proto.html%2Chttp%2Ftests%2Fmedia%2Fvideo-error-abort.html%2Cplugins%2Freturn-npobject.html%2Chttp%2Ftests%2Fcanvas%2Fwebgl%2Forigin-clean-conformance.html%2Chttp%2Ftests%2Fsecurity%2Flocal-video-source-from-remote.html

crash
fast/js/cyclic-proto.html 
http/tests/media/video-error-abort.html 
plugins/return-npobject.html 

timeout
http/tests/canvas/webgl/origin-clean-conformance.html 
http/tests/security/local-video-source-from-remote.html

[WebKit Review Bot]

http://trac.webkit.org/changeset/80461 might have broken GTK Linux 32-bit Release

[David Levin]

If you could, it would be helpful if you re-open the original bug when rolling something out.

Thanks for handling this breakage Ukai!

[Fumitoshi Ukai]

(In reply to comment #6)
> If you could, it would be helpful if you re-open the original bug when rolling something out.

Ah, I should have done that. 
I'll do.
Thanks!

[Eric Seidel (no email)]

Ideally the commit-queue should know how to do it when landing rollout patches, but it's not that smart yet. :)

It probably could be taught to do so by just checking self._patch.is_rollout() in:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/bot/commitqueuetask.py#L214
and telling self._delegate to reopen the bug.