Bug 55863 - REGRESSION(r80458): caused tests to crash on several chromium bots (Requested by ukai on #webkit).
Summary: REGRESSION(r80458): caused tests to crash on several chromium bots (Requested...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: WebKit Review Bot
Depends on:
Blocks: 53925
  Show dependency treegraph
Reported: 2011-03-07 01:53 PST by WebKit Review Bot
Modified: 2011-03-07 18:58 PST (History)
4 users (show)

See Also:

ROLLOUT of r80458 (14.14 KB, patch)
2011-03-07 01:53 PST, WebKit Review Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2011-03-07 01:53:09 PST
http://trac.webkit.org/changeset/80458 broke the build:
caused tests to crash on several chromium bots (Requested by ukai on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2011-03-07 01:53:31 PST
Created attachment 84927 [details]
ROLLOUT of r80458

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Fumitoshi Ukai 2011-03-07 01:55:53 PST
Comment on attachment 84927 [details]
ROLLOUT of r80458

Clearing flags on attachment: 84927

Committed r80461: <http://trac.webkit.org/changeset/80461>
Comment 3 Fumitoshi Ukai 2011-03-07 01:56:01 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Fumitoshi Ukai 2011-03-07 02:12:14 PST


Comment 5 WebKit Review Bot 2011-03-07 03:09:33 PST
http://trac.webkit.org/changeset/80461 might have broken GTK Linux 32-bit Release
Comment 6 David Levin 2011-03-07 10:23:26 PST
If you could, it would be helpful if you re-open the original bug when rolling something out.

Thanks for handling this breakage Ukai!
Comment 7 Fumitoshi Ukai 2011-03-07 17:43:22 PST
(In reply to comment #6)
> If you could, it would be helpful if you re-open the original bug when rolling something out.

Ah, I should have done that. 
I'll do.
Comment 8 Eric Seidel (no email) 2011-03-07 18:58:06 PST
Ideally the commit-queue should know how to do it when landing rollout patches, but it's not that smart yet. :)

It probably could be taught to do so by just checking self._patch.is_rollout() in:
and telling self._delegate to reopen the bug.