Bug 55853 - Move MD5/SHA1 tests to somewhere outside their constructors
Summary: Move MD5/SHA1 tests to somewhere outside their constructors
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 21010
Blocks:
  Show dependency tree / graph
 
Reported: 2011-03-06 18:05 PST by Yuta Kitamura
Modified: 2011-04-18 22:44 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2011-03-06 18:05:51 PST 
WTF::MD5 and WTF::SHA1 classes run unit tests in their constructors. We should move these somewhere else.

Comment from Kent Tamura in bug 55039:
> I don't like having tests in SHA1.cpp and they are called by the constructor though I understand it's same as MD5.
> Would you file a bug about the test location of SHA1 and MD5, and add a FIXME comment please?
Comment 1 Yuta Kitamura 2011-04-18 22:44:39 PDT 
Making this bug depend on bug 21010, because C++ unit test should be a perfect place to put these tests.