WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
55853
Move MD5/SHA1 tests to somewhere outside their constructors
https://bugs.webkit.org/show_bug.cgi?id=55853
Summary
Move MD5/SHA1 tests to somewhere outside their constructors
Yuta Kitamura
Reported
2011-03-06 18:05:51 PST
WTF::MD5 and WTF::SHA1 classes run unit tests in their constructors. We should move these somewhere else. Comment from Kent Tamura in
bug 55039
:
> I don't like having tests in SHA1.cpp and they are called by the constructor though I understand it's same as MD5. > Would you file a bug about the test location of SHA1 and MD5, and add a FIXME comment please?
Attachments
Add attachment
proposed patch, testcase, etc.
Yuta Kitamura
Comment 1
2011-04-18 22:44:39 PDT
Making this bug depend on
bug 21010
, because C++ unit test should be a perfect place to put these tests.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug