Bug 55850 – Implement -hyphenate-limit-{before,after}

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

Implement -hyphenate-limit-{before,after}

<rdar://problem/9093327>

Created attachment 84900 [details]
Parse, apply and respect -webkit-hyphenate-limit-{before,after}

[WebKit Review Bot]

Attachment 84900 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/rendering/style/RenderStyle.cpp:408:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/style/RenderStyle.cpp:409:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 2 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Oliver Hunt]

Comment on attachment 84900 [details]
Parse, apply and respect -webkit-hyphenate-limit-{before,after}

View in context: https://bugs.webkit.org/attachment.cgi?id=84900&action=review

r=me, but consider the short suggestion

> Source/WebCore/rendering/style/StyleRareInheritedData.h:90
> +    int hyphenationLimitBefore;
> +    int hyphenationLimitAfter;

It seems reasonable to just use shorts here -- i can't imagine needing a hyphenation limit > 8192, and we can save a word off of rare data

(In reply to comment #4)
> (From update of attachment 84900 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=84900&action=review
> 
> r=me, but consider the short suggestion
> 
> > Source/WebCore/rendering/style/StyleRareInheritedData.h:90
> > +    int hyphenationLimitBefore;
> > +    int hyphenationLimitAfter;
> 
> It seems reasonable to just use shorts here -- i can't imagine needing a hyphenation limit > 8192, and we can save a word off of rare data

Good idea. Just need to figure out the clamping. Thanks for the review!

Committed r80438.
<http://trac.webkit.org/changeset/80438>