Bug 55842 – [Qt] Simplify how QWebFrame::requestedUrl() is obtained

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Caio Marcelo de Oliveira Filho]

The idea here is to always store the requested url once frame loader start the provisional load. And clears it when the load is finished -- since it is available in the document loader.

The stored value is useful for the error cases, when the load wasn't successful. The idea is similar to the old implementation, but simpler.

This change is related to bug 32723. There, I want to decouple the clearing of the frame from the URL passed in setUrl(), by removing the argument url from the call to DocumentWriter::begin(), and having the value stored in case of fail is useful to implement QWebFrame::url().

[Caio Marcelo de Oliveira Filho]

Created attachment 84888 [details]
patch

[Kenneth Rohde Christiansen]

Comment on attachment 84888 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84888&action=review

Your changelog does not explain why this new code is equal to the old code, or why the old code is wrong. Are these edge cases not valid anymore?

> Source/WebKit/qt/ChangeLog:9
> +        so we now it'll be available in the DocumentLoader.

know?

[Caio Marcelo de Oliveira Filho]

Created attachment 84889 [details]
patch with improved ChangeLog

[Caio Marcelo de Oliveira Filho]

Antonio, added you to CC since most of the requestedUrl() was implemented by you back in time. Would be very helpful if you could take a look / review this patch, or point some one who would be able to review it. :-)

[WebKit Commit Bot]

Comment on attachment 84889 [details]
patch with improved ChangeLog

Clearing flags on attachment: 84889

Committed r80768: <http://trac.webkit.org/changeset/80768>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.