Bug 55827 - Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
: Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: Other Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-03-05 13:30 PST by
Modified: 2011-03-07 10:28 PST (History)


Attachments
Patch (55.60 KB, patch)
2011-03-05 13:36 PST, Sam Weinig
andersca: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-03-05 13:30:03 PST
Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
------- Comment #1 From 2011-03-05 13:36:22 PST -------
Created an attachment (id=84874) [details]
Patch
------- Comment #2 From 2011-03-05 13:38:21 PST -------
Attachment 84874 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/platform/mac-wk2/Skipped', u'S..." exit_code: 1

Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h:126:  The parameter name "function" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/wx/WebKitSupport/FrameLoaderClientWx.h:200:  The parameter name "function" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/chromium/src/FrameLoaderClientImpl.h:117:  The parameter name "function" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 49 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #3 From 2011-03-07 10:28:59 PST -------
Landed in 80475.