WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
55825
Web Inspector: remove groupName from objectId
https://bugs.webkit.org/show_bug.cgi?id=55825
Summary
Web Inspector: remove groupName from objectId
Ilya Tikhonovsky
Reported
2011-03-05 07:37:03 PST
%subj%
Attachments
[patch] initial version
(8.02 KB, patch)
2011-03-05 07:39 PST
,
Ilya Tikhonovsky
pfeldman
: review-
Details
Formatted Diff
Diff
[patch] second iteration
(7.09 KB, patch)
2011-03-08 13:40 PST
,
Ilya Tikhonovsky
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1
2011-03-05 07:39:51 PST
Created
attachment 84865
[details]
[patch] initial version
Pavel Feldman
Comment 2
2011-03-05 08:54:22 PST
Comment on
attachment 84865
[details]
[patch] initial version View in context:
https://bugs.webkit.org/attachment.cgi?id=84865&action=review
> Source/WebCore/ChangeLog:9 > + ():
Please remove these from ChangeLog.
> Source/WebCore/inspector/InjectedScriptSource.js:48 > + this._idToObjectInfo = {};
Not all the objects have group names. I'd suggest that you simply create a separate map for id -> groupName binding. Otherwise, overhead.
Ilya Tikhonovsky
Comment 3
2011-03-08 13:40:44 PST
Created
attachment 85087
[details]
[patch] second iteration comments addressed
Ilya Tikhonovsky
Comment 4
2011-03-08 22:32:52 PST
Comment on
attachment 85087
[details]
[patch] second iteration Clearing flags on attachment: 85087 Committed
r80623
: <
http://trac.webkit.org/changeset/80623
>
Ilya Tikhonovsky
Comment 5
2011-03-08 22:33:02 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug