Bug 55825 - Web Inspector: remove groupName from objectId
Summary: Web Inspector: remove groupName from objectId
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-05 07:37 PST by Ilya Tikhonovsky
Modified: 2011-03-08 22:33 PST (History)
10 users (show)

See Also:

Attachments
[patch] initial version (8.02 KB, patch)
2011-03-05 07:39 PST, Ilya Tikhonovsky 		pfeldman: review-
Details | Formatted Diff | Diff
[patch] second iteration (7.09 KB, patch)
2011-03-08 13:40 PST, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2011-03-05 07:37:03 PST 
%subj%
Comment 1 Ilya Tikhonovsky 2011-03-05 07:39:51 PST 
Created attachment 84865 [details]
[patch] initial version
Comment 2 Pavel Feldman 2011-03-05 08:54:22 PST 
Comment on attachment 84865 [details]
[patch] initial version

View in context: https://bugs.webkit.org/attachment.cgi?id=84865&action=review

> Source/WebCore/ChangeLog:9
> +        ():

Please remove these from ChangeLog.

> Source/WebCore/inspector/InjectedScriptSource.js:48
> +    this._idToObjectInfo = {};

Not all the objects have group names. I'd suggest that you simply create a separate map for id -> groupName binding. Otherwise, overhead.
Comment 3 Ilya Tikhonovsky 2011-03-08 13:40:44 PST 
Created attachment 85087 [details]
[patch] second iteration

comments addressed
Comment 4 Ilya Tikhonovsky 2011-03-08 22:32:52 PST 
Comment on attachment 85087 [details]
[patch] second iteration

Clearing flags on attachment: 85087

Committed r80623: <http://trac.webkit.org/changeset/80623>
Comment 5 Ilya Tikhonovsky 2011-03-08 22:33:02 PST 
All reviewed patches have been landed.  Closing bug.