Bug 55821 - Web Inspector: move breakpoint column adjustment to debugger model
Summary: Web Inspector: move breakpoint column adjustment to debugger model
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-05 04:17 PST by Pavel Podivilov
Modified: 2011-03-23 03:25 PDT (History)
10 users (show)

See Also:

Attachments
Patch. (3.45 KB, patch)
2011-03-05 04:18 PST, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
Patch. (3.10 KB, patch)
2011-03-09 03:43 PST, Pavel Podivilov 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-03-05 04:17:31 PST 
Web Inspector: move breakpoint column adjustment to debugger model
Comment 1 Pavel Podivilov 2011-03-05 04:18:51 PST 
Created attachment 84859 [details]
Patch.
Comment 2 Pavel Feldman 2011-03-06 11:07:11 PST 
Comment on attachment 84859 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=84859&action=review

> Source/WebCore/inspector/front-end/DebuggerModel.js:83
> +            var script = this._scripts[id];

So you rely upon the fact that _scripts are sorted in the compilation order, right?
This is right, but a bit fragile. Could you mention it in the comments and provide a test? Clearing r? while waiting for test.

> Source/WebCore/inspector/front-end/DebuggerModel.js:100
> +        }        

Please revert this change.
Comment 3 Pavel Podivilov 2011-03-09 03:43:17 PST 
Created attachment 85151 [details]
Patch.
Comment 4 Pavel Podivilov 2011-03-09 03:45:07 PST 
(In reply to comment #2)
> (From update of attachment 84859 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=84859&action=review
> 
> > Source/WebCore/inspector/front-end/DebuggerModel.js:83
> > +            var script = this._scripts[id];
> 
> So you rely upon the fact that _scripts are sorted in the compilation order, right?
> This is right, but a bit fragile. Could you mention it in the comments and provide a test? Clearing r? while waiting for test.

Replaced with less fragile code that searches for the leftmost script on the line. This code is tested by debug-inlined-scripts.html.

> 
> > Source/WebCore/inspector/front-end/DebuggerModel.js:100
> > +        }        
> 
> Please revert this change.

Done.
Comment 5 Pavel Podivilov 2011-03-23 03:25:37 PDT 
Commited in r80702.