RESOLVED FIXED Bug 55821
Web Inspector: move breakpoint column adjustment to debugger model 
https://bugs.webkit.org/show_bug.cgi?id=55821
Summary Web Inspector: move breakpoint column adjustment to debugger model
Pavel Podivilov
Reported 2011-03-05 04:17:31 PST
Web Inspector: move breakpoint column adjustment to debugger model
Attachments
Patch. (3.45 KB, patch)
2011-03-05 04:18 PST, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Patch. (3.10 KB, patch)
2011-03-09 03:43 PST, Pavel Podivilov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-03-05 04:18:51 PST
Created attachment 84859 [details] Patch.
Pavel Feldman
Comment 2 2011-03-06 11:07:11 PST
Comment on attachment 84859 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=84859&action=review > Source/WebCore/inspector/front-end/DebuggerModel.js:83 > + var script = this._scripts[id]; So you rely upon the fact that _scripts are sorted in the compilation order, right? This is right, but a bit fragile. Could you mention it in the comments and provide a test? Clearing r? while waiting for test. > Source/WebCore/inspector/front-end/DebuggerModel.js:100 > + } Please revert this change.
Pavel Podivilov
Comment 3 2011-03-09 03:43:17 PST
Created attachment 85151 [details] Patch.
Pavel Podivilov
Comment 4 2011-03-09 03:45:07 PST
(In reply to comment #2) > (From update of attachment 84859 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=84859&action=review > > > Source/WebCore/inspector/front-end/DebuggerModel.js:83 > > + var script = this._scripts[id]; > > So you rely upon the fact that _scripts are sorted in the compilation order, right? > This is right, but a bit fragile. Could you mention it in the comments and provide a test? Clearing r? while waiting for test. Replaced with less fragile code that searches for the leftmost script on the line. This code is tested by debug-inlined-scripts.html. > > > Source/WebCore/inspector/front-end/DebuggerModel.js:100 > > + } > > Please revert this change. Done.
Pavel Podivilov
Comment 5 2011-03-23 03:25:37 PDT
Commited in r80702.
Note You need to log in before you can comment on or make changes to this bug.