Bug 55818 - Web Inspector: [Text editor] Regression in handling DOMNodeInserted/DOMNodeRemoved events
Summary: Web Inspector: [Text editor] Regression in handling DOMNodeInserted/DOMNodeRe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-05 02:05 PST by Andrey Adaikin
Modified: 2011-03-09 03:02 PST (History)
11 users (show)

See Also:

Attachments
Patch (2.70 KB, patch)
2011-03-05 02:11 PST, Andrey Adaikin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2011-03-05 02:05:58 PST 
Newly inserted line rows may have the "lineNumber" property set (e.g. when inserting via a native Undo), thus interfering with the current numeration. We should also delete the "lineNumber" from line rows on DOMNodeRemoved event as a double defense.
Comment 1 Andrey Adaikin 2011-03-05 02:11:12 PST 
Created attachment 84854 [details]
Patch
Comment 2 Pavel Feldman 2011-03-05 03:38:51 PST 
Comment on attachment 84854 [details]
Patch

Test?
Comment 3 Pavel Podivilov 2011-03-09 03:02:09 PST 
Comment on attachment 84854 [details]
Patch

Clearing flags on attachment: 84854

Committed r80632: <http://trac.webkit.org/changeset/80632>
Comment 4 Pavel Podivilov 2011-03-09 03:02:17 PST 
All reviewed patches have been landed.  Closing bug.