Bug 55793 - Add WKPageValidateCommand()
Summary: Add WKPageValidateCommand()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Jeff Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-04 14:45 PST by Jeff Miller
Modified: 2011-03-04 16:59 PST (History)
0 users

See Also:


Attachments
Patch (21.14 KB, patch)
2011-03-04 15:08 PST, Jeff Miller
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Miller 2011-03-04 14:45:19 PST
Add WKPageValidateCommand()
Comment 1 Jeff Miller 2011-03-04 15:08:28 PST
Created attachment 84808 [details]
Patch
Comment 2 Darin Adler 2011-03-04 15:58:19 PST
Comment on attachment 84808 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84808&action=review

> Source/WebKit2/UIProcess/API/C/WKPage.h:378
> +typedef void (*WKPageValidateCommandCallback)(WKStringRef command, bool isEnabled, int state, WKErrorRef, void*);
> +WK_EXPORT void WKPageValidateCommand(WKPageRef page, WKStringRef command, void* context, WKPageValidateCommandCallback callback);

It’s not clear what “state” is; probably needs a comment. Also, the void* probably needs an argument name to make clear it is the context pointer.
Comment 3 Jeff Miller 2011-03-04 16:59:17 PST
Committed http://trac.webkit.org/changeset/80394