RESOLVED FIXED 55793
Add WKPageValidateCommand() 
https://bugs.webkit.org/show_bug.cgi?id=55793
Summary Add WKPageValidateCommand()
Jeff Miller
Reported 2011-03-04 14:45:19 PST
Add WKPageValidateCommand()
Attachments
Patch (21.14 KB, patch)
2011-03-04 15:08 PST, Jeff Miller 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeff Miller
Comment 1 2011-03-04 15:08:28 PST
Created attachment 84808 [details] Patch
Darin Adler
Comment 2 2011-03-04 15:58:19 PST
Comment on attachment 84808 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84808&action=review > Source/WebKit2/UIProcess/API/C/WKPage.h:378 > +typedef void (*WKPageValidateCommandCallback)(WKStringRef command, bool isEnabled, int state, WKErrorRef, void*); > +WK_EXPORT void WKPageValidateCommand(WKPageRef page, WKStringRef command, void* context, WKPageValidateCommandCallback callback); It’s not clear what “state” is; probably needs a comment. Also, the void* probably needs an argument name to make clear it is the context pointer.
Jeff Miller
Comment 3 2011-03-04 16:59:17 PST
Committed http://trac.webkit.org/changeset/80394
Note You need to log in before you can comment on or make changes to this bug.