5579 – WebKit+SVG renders full-filters-example incorrectly

RESOLVED FIXED 5579

WebKit+SVG renders full-filters-example incorrectly

https://bugs.webkit.org/show_bug.cgi?id=5579

Summary WebKit+SVG renders full-filters-example incorrectly

Eric Seidel (no email)

Reported 2005-11-01 02:45:58 PST

WebKit+SVG renders full-filters-example renderers incorrectly This seems to a coordinates/clipping issue.

Attachments
patch to fix the clipping problem (3.12 KB, patch) 2005-11-13 21:43 PST, Erick Tryzelaar	no flags	Details Formatted Diff Diff
properly patching (4.08 KB, patch) 2005-11-13 21:57 PST, Erick Tryzelaar	eric: review-	Details Formatted Diff Diff
added MacDome's suggestions (5.45 KB, patch) 2005-11-13 22:56 PST, Erick Tryzelaar	no flags	Details Formatted Diff Diff
hopefully final patch (5.40 KB, patch) 2005-11-13 23:14 PST, Erick Tryzelaar	no flags	Details Formatted Diff Diff
expanded some tabs (5.41 KB, patch) 2005-11-13 23:15 PST, Erick Tryzelaar	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2005-11-01 02:47:42 PST

Erick is taking a crack at this one.

Erick Tryzelaar

Comment 2 2005-11-13 21:43:18 PST

Created attachment 4684 [details] patch to fix the clipping problem This should fix the clipping problem. So what happened is that the input image was centered at 0,0, but it was supposed to be translated to the (x,y) of the filter location. This should fix the problem.

Erick Tryzelaar

Comment 3 2005-11-13 21:57:42 PST

Created attachment 4685 [details] properly patching

Eric Seidel (no email)

Comment 4 2005-11-13 22:26:07 PST

Comment on attachment 4685 [details] properly patching Erick and I talked about this over IRC. One more round of patch cleanup is necessary here. Also, there seems to be a stray ASSERT.

Erick Tryzelaar

Comment 5 2005-11-13 22:56:58 PST

Created attachment 4686 [details] added MacDome's suggestions

Erick Tryzelaar

Comment 6 2005-11-13 23:14:22 PST

Created attachment 4687 [details] hopefully final patch

Erick Tryzelaar

Comment 7 2005-11-13 23:15:44 PST

Created attachment 4688 [details] expanded some tabs

Eric Seidel (no email)

Comment 8 2005-11-13 23:23:39 PST

Comment on attachment 4688 [details] expanded some tabs Looks good. r=me. I'll land this early this week, hopefully as early as tomorrow.

Eric Seidel (no email)

Comment 9 2005-11-26 14:38:07 PST

Comment on attachment 4688 [details] expanded some tabs Unfortunately this patch no longer applies cleanly after the big merger. There still need to be fixes in this area, however this patch is going to need to be re-worked a bit now. Best if we discuss this over IRC. Removing the review flag for now.

Eric Seidel (no email)

Comment 10 2005-12-06 04:46:17 PST

It actually does a very good job of rendering this example now in TOT, however there are still some clipping issues, which I believe are caused by rounding errors due to our use of ints: http://bugzilla.opendarwin.org/show_bug.cgi?id=4462 Also, this example also suffers from the filter scaling problem: http://bugzilla.opendarwin.org/show_bug.cgi?id=5526

Eric Seidel (no email)

Comment 11 2005-12-08 04:40:40 PST

The only thing left "wrong" is the grainyness: http://bugzilla.opendarwin.org/show_bug.cgi?id=5526 Lack of Text: http://bugzilla.opendarwin.org/show_bug.cgi?id=4883 And integer clipping: http://bugzilla.opendarwin.org/show_bug.cgi?id=4462 I'm not sure that this bug serves a lot of use anymore. But I'll leave it for now.

Nikolas Zimmermann

Comment 12 2007-08-21 14:34:18 PDT

Landed in r25175.

Note You need to log in before you can comment on or make changes to this bug.