Bug 55789 - Update webkit layout test expectations for Chromium for strict mode
Summary: Update webkit layout test expectations for Chromium for strict mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.6
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-04 13:31 PST by mmaly
Modified: 2011-03-08 11:34 PST (History)
5 users (show)

See Also:


Attachments
Changes to the test expectation file for fast/js/mozilla/strict/15.5.5.1 test. (1.27 KB, text/plain)
2011-03-04 13:33 PST, mmaly
no flags Details
Updated test expectations. (1.34 KB, patch)
2011-03-04 13:36 PST, mmaly
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mmaly 2011-03-04 13:31:47 PST
Update for fast/js/mozilla/strict/15.5.5.1-expected.txt for strict mode features implemented in V8.
Strict mode in v8 now correctly throws when assigning to string.length on a string value.
Comment 1 mmaly 2011-03-04 13:33:27 PST
Created attachment 84792 [details]
Changes to the test expectation file for fast/js/mozilla/strict/15.5.5.1 test.
Comment 2 mmaly 2011-03-04 13:34:46 PST
Comment on attachment 84792 [details]
Changes to the test expectation file for fast/js/mozilla/strict/15.5.5.1 test.

Forgot comment.
Comment 3 mmaly 2011-03-04 13:36:32 PST
Created attachment 84793 [details]
Updated test expectations.
Comment 4 mmaly 2011-03-04 17:19:49 PST
Comment on attachment 84793 [details]
Updated test expectations.

Feel free to review but let's not commit this until the chrome test expectations are in. Just committing this could break chrome if this change made it to chrome before the corresponding V8 change.
Comment 5 Dimitri Glazkov (Google) 2011-03-04 18:15:32 PST
Comment on attachment 84793 [details]
Updated test expectations.

hooray
Comment 6 Adam Barth 2011-03-04 18:19:02 PST
Comment on attachment 84793 [details]
Updated test expectations.

Clearing commit-queue flag per earlier comment.
Comment 7 mmaly 2011-03-08 08:56:21 PST
The chrome change landed. This is now ready to land as well.
Comment 8 mmaly 2011-03-08 09:08:59 PST
Comment on attachment 84793 [details]
Updated test expectations.

Ready for commit bots to pick it up. The corresponding Chromium change landed in 77261.

http://src.chromium.org/viewvc/chrome?view=rev&revision=77261
Comment 9 Dimitri Glazkov (Google) 2011-03-08 09:40:28 PST
Comment on attachment 84793 [details]
Updated test expectations.

activate the antimatter reactor.
Comment 10 WebKit Commit Bot 2011-03-08 11:34:12 PST
Comment on attachment 84793 [details]
Updated test expectations.

Clearing flags on attachment: 84793

Committed r80575: <http://trac.webkit.org/changeset/80575>
Comment 11 WebKit Commit Bot 2011-03-08 11:34:18 PST
All reviewed patches have been landed.  Closing bug.