Bug 55786 - JobjectWrapper should inherit from RefCounted rather than implementing its own ref counting
Summary: JobjectWrapper should inherit from RefCounted rather than implementing its ow...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Steve Block
URL:
Keywords:
Depends on:
Blocks: 57859
  Show dependency tree / graph
 
Reported: 2011-03-04 10:45 PST by Steve Block
Modified: 2011-07-20 08:50 PDT (History)
2 users (show)

See Also:

Attachments
Patch (12.22 KB, patch)
2011-07-20 03:23 PDT, Steve Block 		tonyg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2011-03-04 10:45:31 PST 
JobjectWrapper should inherit from RefCounted rather than implementing its own ref counting
Comment 1 Steve Block 2011-07-20 03:23:02 PDT 
Created attachment 101444 [details]
Patch
Comment 2 Tony Gentilcore 2011-07-20 04:07:50 PDT 
Comment on attachment 101444 [details]
Patch

Wow, awesome cleanup, thanks!

Out of curiosity, were there any leaks/bugs here, does this improve perf due to less reference churn, or was this strictly just a maintainability thing? If one of the first two, might be interesting to mention in the ChangeLog.
Comment 3 Steve Block 2011-07-20 04:17:15 PDT 
No, no functional change, just cleanup.
Comment 4 Steve Block 2011-07-20 04:20:24 PDT 
Committed r91355: <http://trac.webkit.org/changeset/91355>