Bug 55782 - [Qt] Need symbian version of cryptographicallyRandomValuesFromOS
Summary: [Qt] Need symbian version of cryptographicallyRandomValuesFromOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: S60 Hardware S60 3rd edition
: P3 Normal
Assignee: Viatcheslav Ostapenko
URL:
Keywords: Qt
Depends on:
Blocks: 50251
  Show dependency tree / graph
 
Reported: 2011-03-04 09:53 PST by Viatcheslav Ostapenko
Modified: 2011-03-07 06:17 PST (History)
2 users (show)

See Also:

Attachments
Symbian version of cryptographicallyRandomValuesFromOS (1.71 KB, patch)
2011-03-04 09:58 PST, Viatcheslav Ostapenko 		no flags Details | Formatted Diff | Diff
Fix style error (1.71 KB, patch)
2011-03-04 10:09 PST, Viatcheslav Ostapenko 		no flags Details | Formatted Diff | Diff
Fix changelog. (1.71 KB, patch)
2011-03-04 12:15 PST, Viatcheslav Ostapenko 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Viatcheslav Ostapenko 2011-03-04 09:53:14 PST 
Symbian doesn't have /dev/urandom and qtwebkit crashes because it cannot open this file.
Comment 1 Viatcheslav Ostapenko 2011-03-04 09:58:49 PST 
Created attachment 84768 [details]
Symbian version of cryptographicallyRandomValuesFromOS
Comment 2 WebKit Review Bot 2011-03-04 10:00:43 PST 
Attachment 84768 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/wtf/OSRandomSource.cpp:59:  Missing space before ( in if(  [whitespace/parens] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Viatcheslav Ostapenko 2011-03-04 10:09:57 PST 
Created attachment 84774 [details]
Fix style error
Comment 4 Viatcheslav Ostapenko 2011-03-04 12:15:54 PST 
Created attachment 84789 [details]
Fix changelog.
Comment 5 Laszlo Gombos 2011-03-04 12:24:26 PST 
Comment on attachment 84789 [details]
Fix changelog.

Looks good to me. r+.
Comment 6 WebKit Commit Bot 2011-03-04 22:03:06 PST 
Comment on attachment 84789 [details]
Fix changelog.

Clearing flags on attachment: 84789

Committed r80407: <http://trac.webkit.org/changeset/80407>
Comment 7 WebKit Commit Bot 2011-03-04 22:03:11 PST 
All reviewed patches have been landed.  Closing bug.