Bug 55771 - Move shared code into SVGStyledTransformableElement::svgAttributeChanged
Summary: Move shared code into SVGStyledTransformableElement::svgAttributeChanged
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks: 55675
  Show dependency tree / graph
 
Reported: 2011-03-04 06:29 PST by Patrick R. Gansterer
Modified: 2011-03-05 04:29 PST (History)
3 users (show)

See Also:

Attachments
Patch (10.65 KB, patch)
2011-03-04 06:48 PST, Patrick R. Gansterer 		zimmermann: review+
zimmermann: commit-queue-
Details | Formatted Diff | Diff
Patch (10.65 KB, patch)
2011-03-04 07:24 PST, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-03-04 06:29:40 PST 
see patch
Comment 1 Patrick R. Gansterer 2011-03-04 06:48:28 PST 
Created attachment 84742 [details]
Patch
Comment 2 Nikolas Zimmermann 2011-03-04 07:18:51 PST 
Comment on attachment 84742 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84742&action=review

Good catch, please fix the base class call before landing though! If you want cq, please upload a new version.

> Source/WebCore/svg/SVGStyledTransformableElement.cpp:86
> +    SVGStyledLocatableElement::synchronizeProperty(attrName);

Erm, you mean svgAttributeChanged here?
Comment 3 Patrick R. Gansterer 2011-03-04 07:24:37 PST 
Created attachment 84746 [details]
Patch
Comment 4 Nikolas Zimmermann 2011-03-04 07:35:11 PST 
Comment on attachment 84746 [details]
Patch

r=me.
Comment 5 WebKit Commit Bot 2011-03-04 09:38:41 PST 
Comment on attachment 84746 [details]
Patch

Clearing flags on attachment: 84746

Committed r80362: <http://trac.webkit.org/changeset/80362>
Comment 6 WebKit Commit Bot 2011-03-04 09:38:47 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Dirk Schulze 2011-03-04 10:00:52 PST 
SVGClipElement and SVGMaskElement are SVGStyledTransformableElements as well, but didn't had this function. Doesn't it influence both elements as well some how?
Comment 8 Nikolas Zimmermann 2011-03-05 04:29:49 PST 
(In reply to comment #7)
> SVGClipElement and SVGMaskElement are SVGStyledTransformableElements as well, but didn't had this function. Doesn't it influence both elements as well some how?

I'd say this is related to the new bug regarding transform + clipPath, we just don't handle it correctly for these elements.