Bug 55762 - Web Inspector: [chromium] pause when script is running is broken
Summary: Web Inspector: [chromium] pause when script is running is broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-04 03:38 PST by Pavel Podivilov
Modified: 2011-03-05 05:45 PST (History)
10 users (show)

See Also:

Attachments
Patch. (1.35 KB, patch)
2011-03-04 03:45 PST, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
Patch. (4.18 KB, patch)
2011-03-04 06:14 PST, Pavel Podivilov 		pfeldman: review-
Details | Formatted Diff | Diff
Patch. (2.22 KB, patch)
2011-03-04 07:03 PST, Pavel Podivilov 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-03-04 03:38:29 PST 
Web Inspector: [chromium] pause when script is running is broken.
Comment 1 Pavel Podivilov 2011-03-04 03:45:53 PST 
Created attachment 84721 [details]
Patch.
Comment 2 Pavel Feldman 2011-03-04 03:55:14 PST 
Comment on attachment 84721 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=84721&action=review

> Source/WebCore/inspector/CodeGeneratorInspector.pm:745
> +    *result = makeString(domain, "_", command);

Please reuse code from dispatch above. Line 712.
Comment 3 Pavel Podivilov 2011-03-04 06:14:18 PST 
Created attachment 84736 [details]
Patch.
Comment 4 Pavel Feldman 2011-03-04 06:24:21 PST 
Comment on attachment 84736 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=84736&action=review

> Source/WebCore/inspector/CodeGeneratorInspector.pm:702
> +    HashMap<String, CallHandler>::iterator it = dispatchMap.end();

Declare lower?

> Source/WebCore/inspector/CodeGeneratorInspector.pm:707
>      if (it == dispatchMap.end()) {

else?
Comment 5 Pavel Podivilov 2011-03-04 07:03:32 PST 
Created attachment 84744 [details]
Patch.
Comment 6 Pavel Podivilov 2011-03-05 05:45:39 PST 
Committed r80420: <http://trac.webkit.org/changeset/80420>