Bug 55752 - Remove default parameter for compatibility in WebFontInfo::familyForChars()
Summary: Remove default parameter for compatibility in WebFontInfo::familyForChars()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-04 01:04 PST by Takayoshi Kochi
Modified: 2011-03-10 20:44 PST (History)
3 users (show)

See Also:


Attachments
Remove default parameter for familyForChars(), which is no longer necessary. (1.29 KB, patch)
2011-03-10 00:56 PST, Takayoshi Kochi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Takayoshi Kochi 2011-03-04 01:04:24 PST
https://bugs.webkit.org/show_bug.cgi?id=55453 introduced an interface change between Chromium and WebKit,
and for maintaining compatibility, WebFontInfo::familyForChars()'s 3rd parameter is declared as a default
parameter (preferredLocale = 0).

Once Chromium side of changes are complete, remove the default parameter.
Comment 1 Takayoshi Kochi 2011-03-10 00:56:14 PST
Created attachment 85293 [details]
Remove default parameter for familyForChars(), which is no longer necessary.
Comment 2 Takayoshi Kochi 2011-03-10 01:16:18 PST
Tony,

Could you please review and commit if this looks good?

This is a clean up of remaining stuff in
https://bugs.webkit.org/show_bug.cgi?id=55453

Thanks!
Comment 3 WebKit Commit Bot 2011-03-10 20:44:51 PST
Comment on attachment 85293 [details]
Remove default parameter for familyForChars(), which is no longer necessary.

Clearing flags on attachment: 85293

Committed r80810: <http://trac.webkit.org/changeset/80810>
Comment 4 WebKit Commit Bot 2011-03-10 20:44:54 PST
All reviewed patches have been landed.  Closing bug.