Bug 55749 - add webkit-patch post-attachment for posting to bugzilla from the commandline
Summary: add webkit-patch post-attachment for posting to bugzilla from the commandline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-03 23:51 PST by Ojan Vafai
Modified: 2011-03-07 21:58 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.52 KB, patch)
2011-03-03 23:51 PST, Ojan Vafai 		no flags Details | Formatted Diff | Diff
Patch (7.04 KB, patch)
2011-03-04 01:01 PST, Ojan Vafai 		abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-03-03 23:51:15 PST 
add webkit-patch post-attachment for posting to bugzilla from the commandline
Comment 1 Ojan Vafai 2011-03-03 23:51:57 PST 
Created attachment 84701 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-03-04 00:32:03 PST 
Don't you want this as post-patch since it assumes it's a patch?  You could do a post-attachment and have it use the attachment paths instead of the patch ones.
Comment 3 Ojan Vafai 2011-03-04 01:01:19 PST 
Created attachment 84706 [details]
Patch
Comment 4 Eric Seidel (no email) 2011-03-04 01:14:42 PST 
Comment on attachment 84706 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84706&action=review

> Tools/Scripts/webkitpy/tool/commands/upload.py:178
> +    help_text = "Attach the the file to the bug as a patch file"

This doens't just do patches, right?  This should handle other mime types just fine, or?
Comment 5 Ojan Vafai 2011-03-04 01:30:55 PST 
(In reply to comment #2)
> Don't you want this as post-patch since it assumes it's a patch?  You could do a post-attachment and have it use the attachment paths instead of the patch ones.

I don't understand. Where is it assuming it's a patch? I specifically want post-attachment. We could add flags for marking for review/commit-queue to post-attachment as well if there's a use-case for posting patch files.


(In reply to comment #4)
> (From update of attachment 84706 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=84706&action=review
> 
> > Tools/Scripts/webkitpy/tool/commands/upload.py:178
> > +    help_text = "Attach the the file to the bug as a patch file"
> 
> This doens't just do patches, right?  This should handle other mime types just fine, or?

Whoops. That's just a copy-paste typo. Will change it to "Attach the the file to the bug"
Comment 6 Adam Barth 2011-03-04 11:26:17 PST 
Comment on attachment 84706 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84706&action=review

My only concern is this command getting confused with the "post" command.  Maybe "attach-to-bug" ?

webkit-patch attach-to-bug 23983 foo.patch

> Tools/Scripts/webkitpy/tool/commands/upload.py:179
> +    argument_names = "BUGID FILEPATH [\"DESCRIPTION\"]"

Normally, we used -m for the description, right?

> Tools/Scripts/webkitpy/tool/commands/upload.py:-207
> -

This removal seems spurious and incorrect.
Comment 7 Ojan Vafai 2011-03-07 21:58:51 PST 
Committed r80537: <http://trac.webkit.org/changeset/80537>