RESOLVED FIXED 55723
lazily autoinstall thirdparty python libraries 
https://bugs.webkit.org/show_bug.cgi?id=55723
Summary lazily autoinstall thirdparty python libraries
Tony Chang
Reported 2011-03-03 16:24:17 PST
lazily autoinstall thirdparty python libraries
Attachments
Patch (18.32 KB, patch)
2011-03-03 16:26 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (18.19 KB, patch)
2011-03-04 10:19 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch for landing (18.42 KB, patch)
2011-04-27 10:13 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2011-03-03 16:26:43 PST
Created attachment 84652 [details] Patch
Tony Chang
Comment 2 2011-03-03 16:29:00 PST
I'm not super excited about this, but I think it's better than what we have currently. I don't like how we have to move the imports to where the object is actually used, but I can't think of another way to make this work.
Eric Seidel (no email)
Comment 3 2011-03-03 16:40:04 PST
I'm not sure I understand what problem you're trying to solve.
Tony Chang
Comment 4 2011-03-03 16:42:16 PST
(In reply to comment #3) > I'm not sure I understand what problem you're trying to solve. About a month ago, the chromium waterfall moved to a new datacenter and > 100 bots were trying to autoinstall packages from sourceforge.net, effectively DOSing them. By autoinstalling less, the bots will be more stable.
Eric Seidel (no email)
Comment 6 2011-03-03 17:11:34 PST
Comment on attachment 84652 [details] Patch I'm confused as to why the import hooks are needed if you're moving the import calls into the functions themselves.
Tony Chang
Comment 7 2011-03-03 17:16:14 PST
(In reply to comment #6) > (From update of attachment 84652 [details]) > I'm confused as to why the import hooks are needed if you're moving the import calls into the functions themselves. If we don't use import hooks, importing anything in thirdparty triggers the downloads. For example, importing thirdparty.BeautifulSoup or thirdparty.mock triggers downloads. I could try pushing all those imports down as well, but that seems a bit more fragile since it's less obvious that importing thirdparty.BeautifulSoup is going to trigger a download (at least thirdparty.autoinstalled.foo has autoinstalled in it).
Tony Chang
Comment 8 2011-03-04 10:19:34 PST
Created attachment 84776 [details] Patch
Tony Chang
Comment 9 2011-04-27 10:13:06 PDT
Created attachment 91307 [details] Patch for landing
Tony Chang
Comment 10 2011-04-27 13:44:24 PDT
Committed r85080: <http://trac.webkit.org/changeset/85080>
Note You need to log in before you can comment on or make changes to this bug.