RESOLVED FIXED 55721
Global IconDatabase should be returned by reference, not as a pointer 
https://bugs.webkit.org/show_bug.cgi?id=55721
Summary Global IconDatabase should be returned by reference, not as a pointer
Brady Eidson
Reported 2011-03-03 16:14:19 PST
Global IconDatabase should be returned by reference, not as a pointer We null check it in a few places, but not most. It's silly - it's should never be null anyways. Fixing...
Attachments
Make it a reference throughout. (38.87 KB, patch)
2011-03-03 16:16 PST, Brady Eidson 		darin: review+
beidson: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2011-03-03 16:16:40 PST
Created attachment 84646 [details] Make it a reference throughout.
WebKit Review Bot
Comment 2 2011-03-03 16:18:22 PST
Attachment 84646 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/qt/Api/qwebsettings.cpp:669: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 3 2011-03-03 16:53:07 PST
r80299
Note You need to log in before you can comment on or make changes to this bug.