Global IconDatabase should be returned by reference, not as a pointer We null check it in a few places, but not most. It's silly - it's should never be null anyways. Fixing...
Created attachment 84646 [details] Make it a reference throughout.
Attachment 84646 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/qt/Api/qwebsettings.cpp:669: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
r80299