Bug 55721 - Global IconDatabase should be returned by reference, not as a pointer
Summary: Global IconDatabase should be returned by reference, not as a pointer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-03 16:14 PST by Brady Eidson
Modified: 2011-03-03 16:53 PST (History)
1 user (show)

See Also:

Attachments
Make it a reference throughout. (38.87 KB, patch)
2011-03-03 16:16 PST, Brady Eidson 		darin: review+
beidson: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2011-03-03 16:14:19 PST 
Global IconDatabase should be returned by reference, not as a pointer

We null check it in a few places, but not most.  It's silly - it's should never be null anyways.

Fixing...
Comment 1 Brady Eidson 2011-03-03 16:16:40 PST 
Created attachment 84646 [details]
Make it a reference throughout.
Comment 2 WebKit Review Bot 2011-03-03 16:18:22 PST 
Attachment 84646 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit/qt/Api/qwebsettings.cpp:669:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brady Eidson 2011-03-03 16:53:07 PST 
r80299