Bug 55702 – Scrubbing <video> with HTTP Live Stream resizes element to 0x0

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jer Noble]

Scrubbing the iPad2 - march 2 event keynote video in Safari on Snow Leopard kills video presentation.

[Jer Noble]

<rdar://problem/9078563>

[Jer Noble]

Created attachment 84620 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 84620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84620&action=review

> Source/WebCore/ChangeLog:9
> +        a HTTP Live Stream.  So we will cache the last valid value returned by QTKit

"an HTTP Live Stream"?

> Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.h:211
> +    FloatSize m_cachedNaturalSize;

You could make this mutable.

> Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:232
> +    , m_cachedNaturalSize(FloatSize())

No need to initialize; FloatSize has its own ctor.

[Jer Noble]

(In reply to comment #3)
> (From update of attachment 84620 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=84620&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        a HTTP Live Stream.  So we will cache the last valid value returned by QTKit
> 
> "an HTTP Live Stream"?

http://owl.english.purdue.edu/owl/resource/540/01/

I guess it depends on whether you pronounce it "aich tee tee pee" or "haich tee tee pee". :-D

> > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.h:211
> > +    FloatSize m_cachedNaturalSize;
> 
> You could make this mutable.

Fantastic idea.

> > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:232
> > +    , m_cachedNaturalSize(FloatSize())
> 
> No need to initialize; FloatSize has its own actor.

Sure.  Thanks!

[Jer Noble]

Committed r81833: <http://trac.webkit.org/changeset/81833>