Bug 55698 - JSVariableObject needs to use WriteBarrier for symboltable property storage
Summary: JSVariableObject needs to use WriteBarrier for symboltable property storage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-03 12:24 PST by Oliver Hunt
Modified: 2011-03-03 14:31 PST (History)
0 users

See Also:


Attachments
Patch (44.69 KB, patch)
2011-03-03 12:33 PST, Oliver Hunt
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-03-03 12:24:35 PST
JSVariableObject needs to use WriteBarrier for symboltable property storage
Comment 1 Oliver Hunt 2011-03-03 12:33:25 PST
Created attachment 84608 [details]
Patch
Comment 2 Darin Adler 2011-03-03 12:34:18 PST
Comment on attachment 84608 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84608&action=review

> Source/JavaScriptCore/runtime/ArgList.h:75
> -            m_buffer = buffer;
> +            m_buffer = reinterpret_cast<Register*>(buffer);

Why is this OK?
Comment 3 Oliver Hunt 2011-03-03 12:36:32 PST
(In reply to comment #2)
> (From update of attachment 84608 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=84608&action=review
> 
> > Source/JavaScriptCore/runtime/ArgList.h:75
> > -            m_buffer = buffer;
> > +            m_buffer = reinterpret_cast<Register*>(buffer);
> 
> Why is this OK?

Register is just another class that wraps a JSValue, which is (essentially) all that WriteBarrier is
Comment 4 Geoffrey Garen 2011-03-03 13:27:53 PST
Comment on attachment 84608 [details]
Patch

r=me
Comment 5 Oliver Hunt 2011-03-03 14:31:29 PST
Committed r80285: <http://trac.webkit.org/changeset/80285>