Bug 55674 – Many tests fail in WebKit2 mode on Windows due to incorrect parsing of absolute Windows-style file: URLs

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adam Roben (:aroben)]

Most/all media tests time out on Windows 7 Release (WebKit2 Tests). See the URL for an example.

[Adam Roben (:aroben)]

<rdar://problem/9080865>

[Adam Roben (:aroben)]

Just looking at media/audio-constructor-preload.html, I see HTMLMediaElement::scheduleLoad get called, but the load timer never fires.

[Adam Roben (:aroben)]

Even though the timer doesn't fire, HTMLMediaElement::load is getting called by JS, so the load is starting. But it looks like we're getting a bogus URL:

file://c/Documents%20and%20Settings/Adam%20Roben/dev/WebKit/OpenSource/LayoutTests/media/content/test.wav

Note the missing colon after "file://c". I think this is actually the root cause of a lot of test failures in WebKit2 on Windows.

[Adam Roben (:aroben)]

Just to close the loop on the timer issue: HTMLMediaElement::load is canceling the timer, since the load is now happening synchronously.

[Adam Roben (:aroben)]

Document::m_baseURL is also missing the colon.

[Adam Roben (:aroben)]

As is Document::m_documentURI.

[Adam Roben (:aroben)]

KURL::parse is getting passed this:

file://c:/Documents and Settings/Adam Roben/dev/WebKit/OpenSource/LayoutTests/media/audio-constructor-preload.html

It parses the colon in "c:" as introducing a port number. But then there is no port number so it continues on its merry way, and "c" gets set as the host. Clearly KURL is buggy with respect to absolute Windows-style file: URLs.

DRT on Windows used CFURL to convert the path into a URL.

[Adam Roben (:aroben)]

I have a workaround. I'll file a new bug for the underlying KURL issue.

[Adam Roben (:aroben)]

Bug 55683 covers the KURL issue.

[Adam Roben (:aroben)]

Created attachment 84574 [details]
Work around a bug in KURL's parsing of Windows-style absolute file: URLs

[Adam Roben (:aroben)]

Committed r80249: <http://trac.webkit.org/changeset/80249>

[WebKit Review Bot]

http://trac.webkit.org/changeset/80249 might have broken Windows 7 Release (Tests)
The following tests are not passing:
animations/combo-transform-rotate+scale.html
animations/keyframe-timing-functions-transform.html
inspector/extensions/extensions-audits.html