Bug 55661 – CSS RGBA fast-path color parsing should clamp of out-of-range alpha values

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Andras Becsi]

RGBA fast-path color parsing does not handle out-of-range alpha values these are handled by the slow-path.

Let the fast-path handle the clamping of out-of-range alpha values.

[Andras Becsi]

Created attachment 84544 [details]
proposed patch with test case

[WebKit Review Bot]

Attachment 84544 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/css/CSSParser.cpp:3884:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/css/CSSParser.cpp:3919:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andras Becsi]

Created attachment 84545 [details]
proposed patch with test case

Fixed the style issues.

[Andreas Kling]

Comment on attachment 84545 [details]
proposed patch with test case

View in context: https://bugs.webkit.org/attachment.cgi?id=84545&action=review

r=me, and thanks for including the test I forgot to commit ages ago! >_<

> Source/WebCore/css/CSSParser.cpp:3945
>      for (int i = 0; i < length; ++i) {

The braces for this block should be removed now.

[Andras Becsi]

Landed in http://trac.webkit.org/changeset/80235.

[Andras Becsi]

Comment on attachment 84545 [details]
proposed patch with test case

Clearing flags.

[WebKit Review Bot]

http://trac.webkit.org/changeset/80235 might have broken GTK Linux 32-bit Release
The following tests are not passing:
fast/canvas/rgba-parsing.html