Bug 55660 - [WK2] Make non-transparent windowless plugins paint on X11
Summary: [WK2] Make non-transparent windowless plugins paint on X11
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 55659
  Show dependency tree / graph
 
Reported: 2011-03-03 03:04 PST by Balazs Kelemen
Modified: 2011-03-10 06:50 PST (History)
3 users (show)

See Also:

Attachments
Patch (22.71 KB, patch)
2011-03-03 09:00 PST, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
Patch (21.91 KB, patch)
2011-03-09 07:17 PST, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2011-03-03 03:04:14 PST 
Let's begin with the most basic case that is needed for Flash to paint.
Comment 1 Balazs Kelemen 2011-03-03 09:00:21 PST 
Created attachment 84569 [details]
Patch
Comment 2 Build Bot 2011-03-03 12:21:43 PST 
Attachment 84569 [details] did not build on win:
Build output: http://queues.webkit.org/results/8083403
Comment 3 Balazs Kelemen 2011-03-09 07:17:46 PST 
Created attachment 85172 [details]
Patch

Fixed the build (speculatively). It also was a logical error.
Comment 4 Andreas Kling 2011-03-10 05:56:42 PST 
Comment on attachment 85172 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85172&action=review

Looks like a good start, r=me. :)

> Source/WebKit2/ChangeLog:24
> +        * WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp: Removed in favour
> +        of a common implementation for X11.

We should remove NetscapePluginGtk.cpp as well.

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1223
> +        // Inject wmode=opaque to make Flash working with these conditions.

s/working with/work in/
Comment 5 Balazs Kelemen 2011-03-10 06:34:59 PST 
Committed r80714: <http://trac.webkit.org/changeset/80714>