Bug 55658 - Allow to use PLATFORM(...) defines in *.messages.in and ifdef related headers
Summary: Allow to use PLATFORM(...) defines in *.messages.in and ifdef related headers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 55719
  Show dependency tree / graph
 
Reported: 2011-03-03 01:53 PST by Oleg Romashin (:romaxa)
Modified: 2011-03-17 10:03 PDT (History)
6 users (show)

See Also:

Attachments
Sorry for my python, but this seems to work fine and fix the problem (3.24 KB, patch)
2011-03-03 01:56 PST, Oleg Romashin (:romaxa) 		no flags Details | Formatted Diff | Diff
One more try, No array hacks, fixed style (3.35 KB, patch)
2011-03-03 16:20 PST, Oleg Romashin (:romaxa) 		no flags Details | Formatted Diff | Diff
Fixed style (finally make style script working in my environment) (3.34 KB, patch)
2011-03-03 17:21 PST, Oleg Romashin (:romaxa) 		no flags Details | Formatted Diff | Diff
Fixed minor bug, and updated unittest (6.45 KB, patch)
2011-03-16 20:36 PDT, Oleg Romashin (:romaxa) 		no flags Details | Formatted Diff | Diff
Fixed build problem (6.77 KB, patch)
2011-03-16 22:03 PDT, Oleg Romashin (:romaxa) 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Romashin (:romaxa) 2011-03-03 01:53:56 PST 
Attempt to compile Qt port with ENABLE_PLUGIN_PROCESS failed with message:

-I../include/WebKit2 -I/usr/src/3rdparty/sqlite/ -I/usr/X11R6/include -I. -I../../../WebKit/Source/WebKit2 -I. -o obj/debug/WebDatabaseManagerMessageReceiver.o generated/WebDatabaseManagerMessageReceiver.cpp
generated/PluginProcessProxyMessageReceiver.cpp:34:22: error: MachPort.h: No such file or directory

Attempt to ifdef 
#if PLATFORM(MAC)
    DidCreateWebProcessConnection(CoreIPC::MachPort connectionIdentifier)
#endif
in PluginProcessProxy.messages.in
does fix the problem, because messages.py ignore those ifdefs
Comment 1 Oleg Romashin (:romaxa) 2011-03-03 01:56:20 PST 
Created attachment 84536 [details]
Sorry for my python, but this seems to work fine and fix the problem
Comment 2 WebKit Review Bot 2011-03-03 01:58:17 PST 
Attachment 84536 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/Scripts/webkit2/messages.py:452:  missing whitespace after ':'  [pep8/E231] [5]
Source/WebKit2/Scripts/webkit2/messages.py:463:  multiple statements on one line (semicolon)  [pep8/E702] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2011-03-03 02:08:45 PST 
Attachment 84536 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8086165
Comment 4 Build Bot 2011-03-03 09:30:00 PST 
Attachment 84536 [details] did not build on win:
Build output: http://queues.webkit.org/results/8084343
Comment 5 Oleg Romashin (:romaxa) 2011-03-03 16:20:08 PST 
Created attachment 84648 [details]
One more try, No array hacks, fixed style
Comment 6 WebKit Review Bot 2011-03-03 16:23:08 PST 
Attachment 84648 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/Scripts/webkit2/messages.py:452:  whitespace after '{'  [pep8/E201] [5]
Source/WebKit2/Scripts/webkit2/messages.py:463:  multiple statements on one line (semicolon)  [pep8/E702] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Oleg Romashin (:romaxa) 2011-03-03 17:21:23 PST 
Created attachment 84660 [details]
Fixed style (finally make style script working in my environment)
Comment 8 Oleg Romashin (:romaxa) 2011-03-07 17:45:52 PST 
Any chance to get this patch reviewed?
Comment 9 Oleg Romashin (:romaxa) 2011-03-16 20:36:18 PDT 
Created attachment 86024 [details]
Fixed minor bug, and updated unittest
Comment 10 Early Warning System Bot 2011-03-16 20:49:30 PDT 
Attachment 86024 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8189410
Comment 11 Build Bot 2011-03-16 21:18:54 PDT 
Attachment 86024 [details] did not build on win:
Build output: http://queues.webkit.org/results/8191387
Comment 12 Oleg Romashin (:romaxa) 2011-03-16 22:03:28 PDT 
Created attachment 86027 [details]
Fixed build problem

Fixed another problem, when messageX ifdefed causing headerX, and messageY non-ifdefed causing headerX, then we should not put headerX into ifdef condition
Comment 13 Oleg Romashin (:romaxa) 2011-03-16 22:22:25 PDT 
Comment on attachment 86027 [details]
Fixed build problem

yep, this compiles now fine
Comment 14 WebKit Commit Bot 2011-03-17 10:01:04 PDT 
The commit-queue encountered the following flaky tests while processing attachment 86027 [details]:

http/tests/cache/history-only-cached-subresource-loads.html bug 56567 (author: joepeck@webkit.org)
The commit-queue is continuing to process your patch.
Comment 15 WebKit Commit Bot 2011-03-17 10:03:22 PDT 
Comment on attachment 86027 [details]
Fixed build problem

Clearing flags on attachment: 86027

Committed r81362: <http://trac.webkit.org/changeset/81362>
Comment 16 WebKit Commit Bot 2011-03-17 10:03:28 PDT 
All reviewed patches have been landed.  Closing bug.