Bug 55658 – Allow to use PLATFORM(...) defines in *.messages.in and ifdef related headers

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Oleg Romashin (:romaxa)]

Attempt to compile Qt port with ENABLE_PLUGIN_PROCESS failed with message:

-I../include/WebKit2 -I/usr/src/3rdparty/sqlite/ -I/usr/X11R6/include -I. -I../../../WebKit/Source/WebKit2 -I. -o obj/debug/WebDatabaseManagerMessageReceiver.o generated/WebDatabaseManagerMessageReceiver.cpp
generated/PluginProcessProxyMessageReceiver.cpp:34:22: error: MachPort.h: No such file or directory

Attempt to ifdef 
#if PLATFORM(MAC)
    DidCreateWebProcessConnection(CoreIPC::MachPort connectionIdentifier)
#endif
in PluginProcessProxy.messages.in
does fix the problem, because messages.py ignore those ifdefs

[Oleg Romashin (:romaxa)]

Created attachment 84536 [details]
Sorry for my python, but this seems to work fine and fix the problem

[WebKit Review Bot]

Attachment 84536 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/Scripts/webkit2/messages.py:452:  missing whitespace after ':'  [pep8/E231] [5]
Source/WebKit2/Scripts/webkit2/messages.py:463:  multiple statements on one line (semicolon)  [pep8/E702] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Attachment 84536 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8086165

[Build Bot]

Attachment 84536 [details] did not build on win:
Build output: http://queues.webkit.org/results/8084343

[Oleg Romashin (:romaxa)]

Created attachment 84648 [details]
One more try, No array hacks, fixed style

[WebKit Review Bot]

Attachment 84648 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/Scripts/webkit2/messages.py:452:  whitespace after '{'  [pep8/E201] [5]
Source/WebKit2/Scripts/webkit2/messages.py:463:  multiple statements on one line (semicolon)  [pep8/E702] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Oleg Romashin (:romaxa)]

Created attachment 84660 [details]
Fixed style (finally make style script working in my environment)

[Oleg Romashin (:romaxa)]

Any chance to get this patch reviewed?

[Oleg Romashin (:romaxa)]

Created attachment 86024 [details]
Fixed minor bug, and updated unittest

[Early Warning System Bot]

Attachment 86024 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8189410

[Build Bot]

Attachment 86024 [details] did not build on win:
Build output: http://queues.webkit.org/results/8191387

[Oleg Romashin (:romaxa)]

Created attachment 86027 [details]
Fixed build problem

Fixed another problem, when messageX ifdefed causing headerX, and messageY non-ifdefed causing headerX, then we should not put headerX into ifdef condition

[Oleg Romashin (:romaxa)]

Comment on attachment 86027 [details]
Fixed build problem

yep, this compiles now fine

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 86027 [details]:

http/tests/cache/history-only-cached-subresource-loads.html bug 56567 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 86027 [details]
Fixed build problem

Clearing flags on attachment: 86027

Committed r81362: <http://trac.webkit.org/changeset/81362>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.