Bug 55653 - Moved all variable object storage inline -- upping the object size limit to 1K
Summary: Moved all variable object storage inline -- upping the object size limit to 1K
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Geoffrey Garen
Depends on:
Reported: 2011-03-02 23:38 PST by Geoffrey Garen
Modified: 2011-03-10 12:25 PST (History)
6 users (show)

See Also:

Patch (89.79 KB, patch)
2011-03-02 23:50 PST, Geoffrey Garen
no flags Details | Formatted Diff | Diff
Patch (94.77 KB, patch)
2011-03-10 11:48 PST, Geoffrey Garen
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-03-02 23:38:16 PST
Moved all variable object storage inline -- upping the object size limit to 1K
Comment 1 Geoffrey Garen 2011-03-02 23:50:16 PST
Created attachment 84527 [details]
Comment 2 Early Warning System Bot 2011-03-03 00:54:32 PST
Attachment 84527 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8077984
Comment 3 Build Bot 2011-03-03 08:26:58 PST
Attachment 84527 [details] did not build on win:
Build output: http://queues.webkit.org/results/8084329
Comment 4 Darin Adler 2011-03-03 10:48:26 PST
Comment on attachment 84527 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=84527&action=review

Please make sure to fix the Qt and Windows builds. Both are failing on the EWS bots.

> Source/WebCore/bindings/js/JSDOMGlobalObject.h:81
> +        Event* m_evt;

Can this be named m_event instead? Why abbreviate event to "evt".
Comment 5 Geoffrey Garen 2011-03-03 13:24:22 PST
Committed r80277: <http://trac.webkit.org/changeset/80277>
Comment 6 WebKit Review Bot 2011-03-03 13:57:08 PST
http://trac.webkit.org/changeset/80277 might have broken Qt Windows 32-bit Debug
Comment 7 Martin Robinson 2011-03-03 15:39:28 PST
This commit seems to have caused many test failures on GTK+:  http://build.webkit.org/results/GTK Linux 64-bit Debug/r80284 (19987)/results.html

I also see many new failures on Intel Release (Tests): http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r80285%20(29135) Though I'm not sure if they are related or not.

I have confirmed that at least some of these tests started failing right ater this commit.
Comment 8 Geoffrey Garen 2011-03-04 11:09:31 PST
Rolled out in http://trac.webkit.org/changeset/80303.
Comment 9 Geoffrey Garen 2011-03-04 11:09:52 PST
Also caused a performance regression on Kraken: bug 55729.
Comment 10 Geoffrey Garen 2011-03-10 11:48:20 PST
Created attachment 85357 [details]
Comment 11 Geoffrey Garen 2011-03-10 12:25:56 PST
Committed r80742: <http://trac.webkit.org/changeset/80742>