WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
55653
Moved all variable object storage inline -- upping the object size limit to 1K
https://bugs.webkit.org/show_bug.cgi?id=55653
Summary
Moved all variable object storage inline -- upping the object size limit to 1K
Geoffrey Garen
Reported
2011-03-02 23:38:16 PST
Moved all variable object storage inline -- upping the object size limit to 1K
Attachments
Patch
(89.79 KB, patch)
2011-03-02 23:50 PST
,
Geoffrey Garen
no flags
Details
Formatted Diff
Diff
Patch
(94.77 KB, patch)
2011-03-10 11:48 PST
,
Geoffrey Garen
oliver
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Geoffrey Garen
Comment 1
2011-03-02 23:50:16 PST
Created
attachment 84527
[details]
Patch
Early Warning System Bot
Comment 2
2011-03-03 00:54:32 PST
Attachment 84527
[details]
did not build on qt: Build output:
http://queues.webkit.org/results/8077984
Build Bot
Comment 3
2011-03-03 08:26:58 PST
Attachment 84527
[details]
did not build on win: Build output:
http://queues.webkit.org/results/8084329
Darin Adler
Comment 4
2011-03-03 10:48:26 PST
Comment on
attachment 84527
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=84527&action=review
Please make sure to fix the Qt and Windows builds. Both are failing on the EWS bots.
> Source/WebCore/bindings/js/JSDOMGlobalObject.h:81 > + Event* m_evt;
Can this be named m_event instead? Why abbreviate event to "evt".
Geoffrey Garen
Comment 5
2011-03-03 13:24:22 PST
Committed
r80277
: <
http://trac.webkit.org/changeset/80277
>
WebKit Review Bot
Comment 6
2011-03-03 13:57:08 PST
http://trac.webkit.org/changeset/80277
might have broken Qt Windows 32-bit Debug
Martin Robinson
Comment 7
2011-03-03 15:39:28 PST
This commit seems to have caused many test failures on GTK+:
http://build.webkit.org/results/GTK
Linux 64-bit Debug/r80284 (19987)/results.html I also see many new failures on Intel Release (Tests):
http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r80285%20(29135
) Though I'm not sure if they are related or not. I have confirmed that at least some of these tests started failing right ater this commit.
Geoffrey Garen
Comment 8
2011-03-04 11:09:31 PST
Rolled out in
http://trac.webkit.org/changeset/80303
.
Geoffrey Garen
Comment 9
2011-03-04 11:09:52 PST
Also caused a performance regression on Kraken:
bug 55729
.
Geoffrey Garen
Comment 10
2011-03-10 11:48:20 PST
Created
attachment 85357
[details]
Patch
Geoffrey Garen
Comment 11
2011-03-10 12:25:56 PST
Committed
r80742
: <
http://trac.webkit.org/changeset/80742
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug