Bug 55646 - Fix location of assert
Summary: Fix location of assert
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-02 19:32 PST by David Grogan
Modified: 2012-02-10 15:11 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.32 KB, patch)
2011-03-02 19:33 PST, David Grogan 		levin: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Grogan 2011-03-02 19:32:43 PST 
Fix location of assert
Comment 1 David Grogan 2011-03-02 19:33:09 PST 
Created attachment 84512 [details]
Patch
Comment 2 Darin Adler 2011-03-02 20:04:47 PST 
Comment on attachment 84512 [details]
Patch

Did the assertion fire in some case? If so, can we check in a test case that shows the failure?
Comment 3 Jeremy Orlow 2011-03-02 20:40:47 PST 
(In reply to comment #2)
> (From update of attachment 84512 [details])
> Did the assertion fire in some case? If so, can we check in a test case that shows the failure?

It fired on one of our tests occasionally.  It was always supposed to be below the scriptExecutionContext() test but accidentally was placed incorrectly (I think during some refactoring...because I always meant for it to be above).  Off the top of my head, I'm not actually sure how we could deterministically cause it to fire.

How much do you care about trying to create a test for it?
Comment 4 Jeremy Orlow 2011-03-02 21:14:02 PST 
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 84512 [details] [details])
> > Did the assertion fire in some case? If so, can we check in a test case that shows the failure?
> 
> It fired on one of our tests occasionally.  It was always supposed to be below the scriptExecutionContext() test but accidentally was placed incorrectly (I think during some refactoring...because I always meant for it to be above).  Off the top of my head, I'm not actually sure how we could deterministically cause it to fire.
> 
> How much do you care about trying to create a test for it?

Actually, I take that back.  I think we should try to construct a test for this.  But David is OOO for the next couple days and I'd like to get this in.  Are you OK with this going in if I create a bug for a test to be created?
Comment 5 David Levin 2011-04-06 13:36:20 PDT 
Comment on attachment 84512 [details]
Patch

Add test (or explain why it can't be done).
Comment 6 David Grogan 2012-02-10 15:11:09 PST 
Obsolete.