Bug 55627 - Manually revert ChromiumDataObject changes.
Summary: Manually revert ChromiumDataObject changes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Daniel Cheng
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-02 16:16 PST by Daniel Cheng
Modified: 2011-03-02 17:00 PST (History)
2 users (show)

See Also:


Attachments
Patch (27.49 KB, patch)
2011-03-02 16:16 PST, Daniel Cheng
no flags Details | Formatted Diff | Diff
Patch (27.49 KB, patch)
2011-03-02 16:49 PST, Daniel Cheng
levin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Cheng 2011-03-02 16:16:13 PST
Manually revert ChromiumDataObject changes.
Comment 1 Daniel Cheng 2011-03-02 16:16:46 PST
Created attachment 84481 [details]
Patch
Comment 2 WebKit Review Bot 2011-03-02 16:19:50 PST
Attachment 84481 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/chromium/ChromiumDataObject.cpp:200:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/platform/chromium/ChromiumDataObject.h:46:  Should only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2011-03-02 16:33:36 PST
Attachment 84481 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8086037
Comment 4 Daniel Cheng 2011-03-02 16:49:50 PST
Created attachment 84487 [details]
Patch
Comment 5 WebKit Review Bot 2011-03-02 16:53:49 PST
Attachment 84487 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/chromium/ChromiumDataObject.cpp:200:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/platform/chromium/ChromiumDataObject.h:46:  Should only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Daniel Cheng 2011-03-02 17:00:54 PST
Committed r80185: <http://trac.webkit.org/changeset/80185>