Bug 55624 - Subframe tear-down should happen later
Summary: Subframe tear-down should happen later
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Frames (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 55209
  Show dependency treegraph
 
Reported: 2011-03-02 15:17 PST by Beth Dakin
Modified: 2011-03-22 13:37 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2011-03-02 15:17:00 PST
There is a comment in HTMLFrameOwnerElement::willRemove() that says:

 // FIXME: It is unclear why this can't be moved to removedFromDocument()
 // this is the only implementation of willRemove in WebCore!

If the contents of HTMLFrameOwnerElement::willRemove() were moved to HTMLFrameOwnerElement::removedFromDocument(), then bugs such as https://bugs.webkit.org/show_bug.cgi?id=55469 would not require strange DRT work-arounds. However, moving this tear-down to be later is not trivial as it causes other crashes in the tests.

We should understand this better, and we should fix it.
Comment 1 Eric Seidel (no email) 2011-03-22 13:37:04 PDT
See more analysis (and attempt at solutions) in bug 55209.