Bug 55623 - Make the runJavaScriptInMainFrame callback send a WKSerializedScriptValueRef
Summary: Make the runJavaScriptInMainFrame callback send a WKSerializedScriptValueRef
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-02 15:13 PST by Timothy Hatcher
Modified: 2011-03-04 09:52 PST (History)
5 users (show)

See Also:


Attachments
Proposed Change (14.22 KB, patch)
2011-03-02 15:20 PST, Timothy Hatcher
darin: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
Proposed Tools Change (5.69 KB, patch)
2011-03-03 16:43 PST, Timothy Hatcher
darin: review+
timothy: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2011-03-02 15:13:00 PST
Make the runJavaScriptInMainFrame callback send a WKSerializedScriptValueRef instead of a WKStringRef.
Comment 1 Timothy Hatcher 2011-03-02 15:20:14 PST
Created attachment 84476 [details]
Proposed Change
Comment 2 Timothy Hatcher 2011-03-02 17:23:33 PST
Landed in r80188.
Comment 3 Timothy Hatcher 2011-03-03 16:43:28 PST
Created attachment 84655 [details]
Proposed Tools Change
Comment 4 Timothy Hatcher 2011-03-03 16:46:31 PST
Reopend to track fixing the tests and relanding after a roll out.
Comment 5 Darin Adler 2011-03-03 16:46:49 PST
Comment on attachment 84655 [details]
Proposed Tools Change

Looks fine.
Comment 6 Build Bot 2011-03-03 20:53:06 PST
Attachment 84655 [details] did not build on win:
Build output: http://queues.webkit.org/results/8078826
Comment 7 Timothy Hatcher 2011-03-03 21:25:08 PST
Adam, any tips why this fails to build on Windows?
Comment 8 Timothy Hatcher 2011-03-04 08:39:41 PST
I forgot the tools patch didn't have the main changes to WebKit2, so it wouldn't build.
Comment 9 Timothy Hatcher 2011-03-04 09:52:11 PST
http://trac.webkit.org/changeset/80358