Bug 55618 – Expose ability to create instance of DOMFileSystem from Chromium side

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Zelidrag Hornung]

We need to expose ability to create instance of DOMFileSystem from Chromium side. Currently, DOMFileSystem instance can be created only though path used to process window.requestFileSystem() call. On Chromium side, we also want to be able to expose special file system object in the context of Chrome extensions. There isn't any good way to do this right now.

[Zelidrag Hornung]

Created attachment 84471 [details]
Created WebKit::WebFrame::createFileSystem() - factory method that lets us create DOMFileSystem instance from Chromium side.

For the lack of better place, I've added this new method as:

WebKit::WebFrame::createFileSystem(int type, const WebString& name, const WebString& path)

Please advise if this should live somewhere else instead.

[Kinuko Yasuda]

Comment on attachment 84471 [details]
Created WebKit::WebFrame::createFileSystem() - factory method that lets us create DOMFileSystem instance from Chromium side.

The patch seems to include unrelated LayoutTests files (and they don't look really changed -- maybe end-of-line issues?).  Can you get rid of them?

I believe this change needs Darin's review.

View in context: https://bugs.webkit.org/attachment.cgi?id=84471&action=review

> Source/WebKit/chromium/ChangeLog:3
> +        Reviewed by Eric Uhrhane.

The reviewer line should be filled after this patch gets reviewed.

[Eric U.]

Comment on attachment 84471 [details]
Created WebKit::WebFrame::createFileSystem() - factory method that lets us create DOMFileSystem instance from Chromium side.

View in context: https://bugs.webkit.org/attachment.cgi?id=84471&action=review

> Source/WebKit/chromium/ChangeLog:4
> +

Yeah, you just leave them as "Reviewed by NOBODY (OOPS!)." and the reviewer who commits it [or the commit queue daemon] will fill it in for you.

Incidentally, I'm not a webkit reviewer.  I have no particular opinion on this side of the change--as Kinuko says, Darin likes to review all the WebKit API CLs.

[Eric U.]

(In reply to comment #3)
> (From update of attachment 84471 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=84471&action=review
> 
> > Source/WebKit/chromium/ChangeLog:4
> > +
> 
> Yeah, you just leave them as "Reviewed by NOBODY (OOPS!)." and the reviewer who commits it [or the commit queue daemon] will fill it in for you.
> 
> Incidentally, I'm not a webkit reviewer.  I have no particular opinion on this side of the change--as Kinuko says, Darin likes to review all the WebKit API CLs.

...except that Darin's out on leave for a bit.  Another reviewer will have to do.

[Zelidrag Hornung]

Created attachment 84658 [details]
fixed comments in ChangeLog

fixed comments in ChangeLog

[Zelidrag Hornung]

Comment on attachment 84471 [details]
Created WebKit::WebFrame::createFileSystem() - factory method that lets us create DOMFileSystem instance from Chromium side.

View in context: https://bugs.webkit.org/attachment.cgi?id=84471&action=review

>> Source/WebKit/chromium/ChangeLog:3

> 
> The reviewer line should be filled after this patch gets reviewed.

fixed

>>> Source/WebKit/chromium/ChangeLog:4

>> 
>> Yeah, you just leave them as "Reviewed by NOBODY (OOPS!)." and the reviewer who commits it [or the commit queue daemon] will fill it in for you.
>> 
>> Incidentally, I'm not a webkit reviewer.  I have no particular opinion on this side of the change--as Kinuko says, Darin likes to review all the WebKit API CLs.
> 
> ...except that Darin's out on leave for a bit.  Another reviewer will have to do.

fixed

[David Levin]

Comment on attachment 84658 [details]
fixed comments in ChangeLog

r- to fix nits (as noted), so I can cq+ the next version of the patch.

[Zelidrag Hornung]

Created attachment 84661 [details]
fixed nits from levin's feedback

fixed nits from levin's feedback

[WebKit Commit Bot]

Comment on attachment 84661 [details]
fixed nits from levin's feedback

Clearing flags on attachment: 84661

Committed r80333: <http://trac.webkit.org/changeset/80333>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.