Bug 55612 - fast/block/positioning/offsetLeft-offsetTop-borders.html doesn't need to be a pixel test
Summary: fast/block/positioning/offsetLeft-offsetTop-borders.html doesn't need to be a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-02 13:48 PST by Jeremy Moskovich
Modified: 2011-03-03 02:58 PST (History)
6 users (show)

See Also:

Attachments
Patch (86.87 KB, patch)
2011-03-02 13:55 PST, Jeremy Moskovich 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Moskovich 2011-03-02 13:48:26 PST 
fast/block/positioning/offsetLeft-offsetTop-borders.html outputs the values of offsetLeft/offsetTop for part of the DOM, if I'm not mistaken this doesn't need to be a pixel test.
Comment 1 Jeremy Moskovich 2011-03-02 13:55:25 PST 
Created attachment 84460 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-03-02 15:01:15 PST 
Comment on attachment 84460 [details]
Patch

Sounds reasonable. Can you also remove the minuses dashing across the screen?
Comment 3 Dimitri Glazkov (Google) 2011-03-02 15:29:14 PST 
(In reply to comment #2)
> (From update of attachment 84460 [details])
> Sounds reasonable. Can you also remove the minuses dashing across the screen?

OTOH, dashes help visually. No worries.
Comment 4 Jeremy Moskovich 2011-03-02 15:30:31 PST 
Comment on attachment 84460 [details]
Patch

Per offline discussion with dglazkov, the dashes are a visual aide so leaving them in.  If anyone feels strongly on the subject, feel free to remove them in a separate patch.
Comment 5 WebKit Commit Bot 2011-03-03 02:56:30 PST 
The commit-queue encountered the following flaky tests while processing attachment 84460 [details]:

http/tests/plugins/cross-frame-object-access.html bug 54791 (author: andersca@apple.com)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2011-03-03 02:58:50 PST 
Comment on attachment 84460 [details]
Patch

Clearing flags on attachment: 84460

Committed r80223: <http://trac.webkit.org/changeset/80223>
Comment 7 WebKit Commit Bot 2011-03-03 02:58:56 PST 
All reviewed patches have been landed.  Closing bug.