Bug 55602 – REGRESSION (r79817): Lots of leaks of FloatingObjects seen on SnowLeopard Intel Leaks bot

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Adam Roben (:aroben)]

The SnowLeopard Intel Leaks bot is showing lots of leaks of FloatingObjects. See the URL for an example.

Maybe this is related to the recent work done in this area in r79817 and r79834?

[Adam Roben (:aroben)]

<rdar://problem/9076342>

[Adam Roben (:aroben)]

The number of leaks jumped from 409 in r79816:

http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15177

...to 3641 in r79817:

http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15178

[Adam Roben (:aroben)]

r79834 seems to have had no effect on the number of leaks:

http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15186
http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15187

[Benjamin Poulain]

It is probably my fault. I have probably forgot at delete when the object are removed from the list.

You can assign to me, I can have a look on Saturday.

[Benjamin Poulain]

Created attachment 84459 [details]
Patch

[Benjamin Poulain]

I went over all the call removing objects of m_floatingObjects and found an instance were I forgot to call deleteAllValues().

I created https://bugs.webkit.org/show_bug.cgi?id=55611 to look for a better way to handle memory so we have a long term solution.

[WebKit Commit Bot]

Comment on attachment 84459 [details]
Patch

Clearing flags on attachment: 84459

Committed r80221: <http://trac.webkit.org/changeset/80221>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Adam Roben (:aroben)]

Great! Leaks went from 12434 in r80218:

http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15291

…to 10964 in r80226:

http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15292

Thanks, Benjamin!