RESOLVED FIXED Bug 55599
r80079 caused incremental Windows builds to fail 
https://bugs.webkit.org/show_bug.cgi?id=55599
Summary r80079 caused incremental Windows builds to fail
Adam Roben (:aroben)
Reported 2011-03-02 12:01:22 PST
r80079 caused incremental Windows builds to fail
Attachments
Patch (2.90 KB, patch)
2011-03-02 12:02 PST, Adam Roben (:aroben) 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-03-02 12:02:19 PST
Here's the build that failed: http://build.webkit.org/builders/Windows%20Debug%20%28Build%29/builds/31688 The errors were: 10>WebKit2WebProcess.res : fatal error LNK1241: resource file WebKit2WebProcess.res already specified 11>FindSafari.res : fatal error LNK1241: resource file FindSafari.res already specified
Adam Roben (:aroben)
Comment 2 2011-03-02 12:02:48 PST
Created attachment 84445 [details] Patch
Tony Chang
Comment 3 2011-03-02 12:43:38 PST
Comment on attachment 84445 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84445&action=review > Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py:24 > + for extension in ['manifest', 'pch', 'res']: Nit: Using a tuple instead of a list is a bit more efficient.
Adam Roben (:aroben)
Comment 4 2011-03-02 12:49:40 PST
Committed r80158: <http://trac.webkit.org/changeset/80158>
Note You need to log in before you can comment on or make changes to this bug.