Bug 55575 - Web Inspector: remove InjectedScriptHost -> DOMAgent dependency.
Summary: Web Inspector: remove InjectedScriptHost -> DOMAgent dependency.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-02 07:15 PST by Pavel Feldman
Modified: 2011-03-02 09:40 PST (History)
10 users (show)

See Also:

Attachments
Patch (35.77 KB, patch)
2011-03-02 07:17 PST, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Patch (35.79 KB, patch)
2011-03-02 09:22 PST, Pavel Feldman 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-03-02 07:15:59 PST 
Patch to follow.
Comment 1 Pavel Feldman 2011-03-02 07:17:39 PST 
Created attachment 84416 [details]
Patch
Comment 2 Yury Semikhatsky 2011-03-02 07:23:09 PST 
Comment on attachment 84416 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84416&action=review

> Source/WebCore/inspector/InspectorRuntimeAgent.cpp:57
> +    InjectedScript injectedScript = m_injectedScriptHost->injectedScriptForMainFrame();

Injected script where the objectId was created should be used instead. r- for this.
Comment 3 Yury Semikhatsky 2011-03-02 07:28:17 PST 
Comment on attachment 84416 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84416&action=review

> Source/WebCore/inspector/InspectorDOMAgent.h:62
> +class ScriptValue;

Remove this?

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:426
> +        function resolvedNode(objectPayload)

resolvedNode -> didResolveNode?
Comment 4 Pavel Feldman 2011-03-02 09:22:14 PST 
Created attachment 84425 [details]
Patch
Comment 5 Pavel Feldman 2011-03-02 09:40:14 PST 
Committed r80141: <http://trac.webkit.org/changeset/80141>