Bug 55572 - Check for spaces in names doesn't take into account non-alphanumeric characters
Summary: Check for spaces in names doesn't take into account non-alphanumeric characters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows Vista
: P1 Normal
Assignee: Berend-Jan Wever
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-02 05:16 PST by Berend-Jan Wever
Modified: 2011-06-18 12:33 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.38 KB, application/octet-stream)
2011-03-02 05:19 PST, Berend-Jan Wever 		no flags Details
Better patch (1.38 KB, patch)
2011-03-02 06:19 PST, Berend-Jan Wever 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Berend-Jan Wever 2011-03-02 05:16:34 PST 
/WebKit/Tools/Scripts/VCSUtils.pm@1671:
     changeLogNameError("'$name' does not contain a space!  ChangeLogs should contain your full name.") unless ($name =~ /\w \w/);

I had set my name to "B.J. Wever", and wasn't allowed to create a changelog because it "does not contain a space", which is incorrect. Since my full-full name is "Berend-Jan Wever", which also has non-alphameric characters, I'm fixing the check, rather than the message.
Comment 1 Berend-Jan Wever 2011-03-02 05:19:26 PST 
Created attachment 84408 [details]
Patch
Comment 2 Berend-Jan Wever 2011-03-02 06:19:46 PST 
Created attachment 84411 [details]
Better patch
Comment 3 Eric Seidel (no email) 2011-03-02 10:25:59 PST 
Comment on attachment 84411 [details]
Better patch

I'm confued.  "B.J. Wever" has a space in it, doesn't it?  What's it matching?  Is it incorrectly picking up on ly part of your name?

This change looks fine though, but I don't really understand how the old code failed for you.
Comment 4 Alexey Proskuryakov 2011-03-02 12:17:59 PST 
"B.J. Wever" obviously doesn't match /\w \w/ indeed - \w is letters, digits, and underscores.
Comment 5 Eric Seidel (no email) 2011-03-02 12:23:13 PST 
I see.  the "." doesn't match the \w.  Thank you ap.
Comment 6 WebKit Review Bot 2011-06-18 12:33:40 PDT 
Comment on attachment 84411 [details]
Better patch

Clearing flags on attachment: 84411

Committed r89196: <http://trac.webkit.org/changeset/89196>
Comment 7 WebKit Review Bot 2011-06-18 12:33:44 PDT 
All reviewed patches have been landed.  Closing bug.